Skip to content

Conversation

@luizcarloscf
Copy link
Contributor

@luizcarloscf luizcarloscf commented May 22, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #921

Link to prove your SVG is correct and up-to-date.

https://mariadb.com/about-us/logos/

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label May 22, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great if you could add non-font versions like this, and keep the font versions like the current ones (just a plain color). What do you think? 🙂

image

@luizcarloscf
Copy link
Contributor Author

I think this logo is actually from the MariaDB Foundation: MariaDB Foundation.

The usage terms at official site:

Basic Usage Guidelines

Do not rotate the MariaDB logo, choose the appropriate format (vertical or horizontal).
Do not change the color of the MariaDB logo, only use the versions provided on this page.
Be sure to scale the MariaDB logo proportionately.
Allow an appropriate amount of white space around the MariaDB logo.

I'm not really sure, I don't know much about the project...

@Panquesito7
Copy link
Member

I think this logo is actually from the MariaDB Foundation: MariaDB Foundation.

The usage terms at official site:

Basic Usage Guidelines
Do not rotate the MariaDB logo, choose the appropriate format (vertical or horizontal).
Do not change the color of the MariaDB logo, only use the versions provided on this page.
Be sure to scale the MariaDB logo proportionately.
Allow an appropriate amount of white space around the MariaDB logo.

I'm not really sure, I don't know much about the project...

Ahh, I see I see. That's fine, then. Feel free to keep it as-is. :)

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀

image

image

@Panquesito7 Panquesito7 requested a review from lunatic-fox May 22, 2023 16:44
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! ✔
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox merged commit fddc6dd into devicons:develop May 31, 2023
@luizcarloscf luizcarloscf deleted the 921-mariadb-icons branch June 6, 2023 12:21
@Snailedlt Snailedlt mentioned this pull request Oct 7, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants