Skip to content

Conversation

@Gautam25Raj
Copy link
Contributor

  • Add reactrouter icons

  • Update devicon.json

…dmark, reactrouter-plain, reactrouter-plain-wordmark)

* Add reactrouter icons

* Update devicon.json
@ConX ConX added the feature:icon PR when a new icon is ready to be added to the collection label May 18, 2023
@Gautam25Raj Gautam25Raj changed the base branch from master to develop May 18, 2023 15:32
* Remove alt text

* Update font version
@Gautam25Raj Gautam25Raj requested a review from Panquesito7 May 20, 2023 10:40
@Gautam25Raj Gautam25Raj requested a review from Panquesito7 May 21, 2023 20:56
Panquesito7
Panquesito7 previously approved these changes May 22, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

image

image

- Add comma to split items of `tags` in `devicon.json`.
- Remove `height` and `width` and replace by `viewBox`.
- Remove fill color from plain versions.
@lunatic-fox
Copy link
Contributor

Just to be extra sure after the modification.
Color #f44250 will be added by color property of devicon.json.

@lunatic-fox lunatic-fox requested a review from Panquesito7 May 22, 2023 23:12
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔
Thank you for this contribution! 🚀

@Panquesito7 Panquesito7 merged commit 3ceb1f0 into devicons:develop May 23, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…mark) (devicons#1765)

* new icon: reactrouter (reactrouter-original, reactrouter-original-wordmark, reactrouter-plain, reactrouter-plain-wordmark)

* Add reactrouter icons

* Update devicon.json

* Update devicon.json

* Remove alt text

* Update font version

* Update devicon.json

* Fixes
- Add comma to split items of `tags` in `devicon.json`.
- Remove `height` and `width` and replace by `viewBox`.
- Remove fill color from plain versions.

---------

Co-authored-by: Josélio Júnior <[email protected]>
Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants