Skip to content

Conversation

@kilianpaquier
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Closes #1736

Link to prove your SVG is correct and up-to-date.

https://angular.io/presskit#angular-material

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label May 13, 2023
Panquesito7
Panquesito7 previously approved these changes May 13, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🚀

image
image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the plain icon to versions.svg in devicon.json (hope you don't mind) :)

The PR looks excellent! 💯
Thank you for another great PR @kilianpaquier 🚀

@Snailedlt Snailedlt requested a review from lunatic-fox May 16, 2023 18:59
@Panquesito7 Panquesito7 merged commit 60b8436 into devicons:develop May 16, 2023
@lunatic-fox
Copy link
Contributor

⚠ Not a big issue, but icons are without a newline at the end.

@Snailedlt
Copy link
Collaborator

@lunatic-fox Yeah, not a big issue :)

PS: please check discord, and don't merge any PR's today due to release attempt

@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* new icon: angularmaterial (original, plain)

* Add plain version to versions.svg

---------

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants