Skip to content

Conversation

@sinuheshinbr
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #984

Link to prove your SVG is correct and up-to-date.

https://www.prisma.io/

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello again! 👋🏼
The icons are pretty good, but they are different from the official logos, please consider to use the listed below to base the new icons.

original

original-wordmark

In devicon.json the color property was already changed from #0c344b to #2D3748.

@lunatic-fox lunatic-fox changed the title new icon: Prisma (original, original-wordmark) new icon: prisma (original, original-wordmark) Apr 25, 2023
@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Apr 26, 2023
@lunatic-fox
Copy link
Contributor

original
original-wordmark

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great work! ✔
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox requested a review from Panquesito7 April 28, 2023 18:41
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for contributing. 🚀
Thanks for showing the screenshots, @lunatic-fox! 😄

@Panquesito7 Panquesito7 merged commit 8a0289a into devicons:develop Apr 28, 2023
@sinuheshinbr sinuheshinbr deleted the feature/prisma branch May 1, 2023 00:07
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* added prisma

* centralized original icon

* Fix `devicon.json`.
- Add `altnames` to `prisma` entry
- Change `color` to `#2D3748`

* updated icons

* updated devicon

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Optimize icons

---------

Co-authored-by: Josélio Júnior <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants