new icon: pnpm (original, original-wordmark, plain, plain-wordmark) #1666

felipe-heredia · 2023-02-04T15:15:17Z

Double-check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #1068

Link to prove your SVG is correct and up-to-date.

Note: I just added the original without a wordmark because the width of 128 cannot work perfectly and it is my first PR, so I don't know how to do that. If someone can help me, I can add the wordmark.

devicons#1068

Panquesito7 · 2023-02-07T07:09:32Z

Hmm. I'm not sure if there's a way to use the official wordmark logo with 128x128 size.
@devicons/supporter, thoughts on this?

Snailedlt · 2023-02-07T18:15:09Z

@Panquesito7 Can't we just remove the height and width attributes and resize it using the tools explained in our "Recommended resources and tools" wiki page?

icons/pnpm/pnpm-plain.svg

icons/pnpm/pnpm-plain-wordmark.svg

icons/pnpm/pnpm-original.svg

icons/pnpm/pnpm-original-wordmark.svg

devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Snailedlt

We're getting there 🚀
Now we just need to:

resize and center pnpm-original-wordmark.svg
center and unite paths for pnpm-plain-wordmark.svg
unite paths for pnpm-plain.svg

icons/pnpm/pnpm-plain-wordmark.svg

icons/pnpm/pnpm-original.svg

icons/pnpm/pnpm-plain.svg

icons/pnpm/pnpm-original-wordmark.svg

github-actions · 2023-03-23T09:04:23Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7

Looks good! Thanks. 🚀

Snailedlt

Great job so far. Only thing left to fix now is the unrelated changes in devicon.json (see comments below) :)

devicon.json

Snailedlt

Looks good now! ✔️
Thank you @felipesuri for the contribution, and thank you @lunatic-fox for the quick fix 💯

…evicons#1666) * new icon: pnpm devicons#1068 * remove pnpm wordmark * feat: add pnpm wordmark * Update icons/pnpm/pnpm-plain.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update icons/pnpm/pnpm-plain-wordmark.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update icons/pnpm/pnpm-original.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update icons/pnpm/pnpm-original-wordmark.svg Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> * Optimize icons * Update devicon.json * Update devicon.json --------- Co-authored-by: Josélio Júnior <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: David Leal <[email protected]>

felipe-heredia added 3 commits February 3, 2023 19:43

new icon: pnpm

ef0d8aa

devicons#1068

remove pnpm wordmark

1d17f8f

feat: add pnpm wordmark

b7311dc

felipe-heredia changed the title ~~new icon: pnpm (original, plain)~~ new icon: pnpm (original, original-wordark) Feb 4, 2023

felipe-heredia changed the title ~~new icon: pnpm (original, original-wordark)~~ new icon: pnpm (original, original-wordmark) Feb 4, 2023

Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Feb 7, 2023

Panquesito7 linked an issue Feb 7, 2023 that may be closed by this pull request

Icon request: PNPM #1068

Closed

Merge branch 'develop' into develop

572da4f

lunatic-fox changed the title ~~new icon: pnpm (original, original-wordmark)~~ new icon: pnpm (original, original-wordmark, plain, plain-wordmark) Mar 6, 2023

Snailedlt requested changes Mar 6, 2023

View reviewed changes

felipe-heredia and others added 5 commits March 8, 2023 08:31

Update icons/pnpm/pnpm-plain.svg

42a5871

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Update icons/pnpm/pnpm-plain-wordmark.svg

c11a8ec

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Update icons/pnpm/pnpm-original.svg

9dddea2

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Update icons/pnpm/pnpm-original-wordmark.svg

fe13507

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Update devicon.json

accfadd

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

Snailedlt requested changes Mar 15, 2023

View reviewed changes

icons/pnpm/pnpm-plain-wordmark.svg Show resolved Hide resolved

icons/pnpm/pnpm-original.svg Show resolved Hide resolved

icons/pnpm/pnpm-plain.svg Outdated Show resolved Hide resolved

icons/pnpm/pnpm-original-wordmark.svg Show resolved Hide resolved

lunatic-fox added 2 commits March 23, 2023 05:46

Merge branch 'develop' into develop

99f9724

Optimize icons

9c66f1f

lunatic-fox added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Mar 23, 2023

Panquesito7 previously approved these changes Apr 9, 2023

View reviewed changes

Panquesito7 requested a review from Snailedlt April 9, 2023 19:09

lunatic-fox and others added 2 commits April 10, 2023 08:39

Merge branch 'develop' into develop

e124693

Merge branch 'develop' into develop

e99c2a1

Snailedlt requested changes Apr 21, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

lunatic-fox reviewed Apr 21, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Update devicon.json

fce2faf

lunatic-fox dismissed Panquesito7’s stale review via fce2faf April 21, 2023 18:10

lunatic-fox reviewed Apr 21, 2023

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Update devicon.json

d3b19f7

Snailedlt approved these changes Apr 22, 2023

View reviewed changes

Snailedlt requested review from Panquesito7 and lunatic-fox April 22, 2023 13:19

lunatic-fox approved these changes Apr 24, 2023

View reviewed changes

Snailedlt merged commit 421a703 into devicons:develop Apr 24, 2023

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

new icon: pnpm (original, original-wordmark, plain, plain-wordmark) #1666

new icon: pnpm (original, original-wordmark, plain, plain-wordmark) #1666

Uh oh!

Conversation

felipe-heredia commented Feb 4, 2023

Double-check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

Uh oh!

Panquesito7 commented Feb 7, 2023

Uh oh!

Snailedlt commented Feb 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Snailedlt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Snailedlt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Snailedlt left a comment •

edited

Loading