Skip to content

Conversation

@juniornsantos
Copy link
Contributor

@juniornsantos juniornsantos commented Jan 12, 2023

###Adding a New Icon?

  • Add autodesk-3ds-max-product-icon.svg

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thank you for submitting a PR 🙇

I see it's your first time contributing to us. Please read our wiki to know what icons are accepted, and how to request/submit new icons. In particular I'd like you to take a look at this wiki page: Overview-on-Submitting-Icons, and create a new PR following those guidelines

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jan 18, 2023
@lunatic-fox lunatic-fox changed the base branch from master to develop April 29, 2023 22:50
@lunatic-fox lunatic-fox changed the title new icon: Autodesk 3DS Max (1.0) new icon: 3dsmax Apr 29, 2023
@lunatic-fox
Copy link
Contributor

🆗 This pull request is now ready to be reviewed.

@Panquesito7 Panquesito7 changed the title new icon: 3dsmax new icon: 3dsmax (original, plain) Apr 30, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🚀

image

image

@Panquesito7 Panquesito7 requested a review from Snailedlt May 3, 2023 00:32
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution! 🙇

@Snailedlt Snailedlt merged commit 7d9b71c into devicons:develop May 3, 2023
@Snailedlt Snailedlt added feature:icon PR when a new icon is ready to be added to the collection and removed feature:icon PR when a new icon is ready to be added to the collection labels Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* I added the autodesk 3ds max icon to the project

* Update icons and `devicon.json` entry

* Update 3dsmax-plain.svg

* Update devicon.json

---------

Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants