Skip to content

new icon: vault (original, original-wordmark, plain-wordmark) #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 27, 2023
Merged

new icon: vault (original, original-wordmark, plain-wordmark) #1609

merged 7 commits into from
Jan 27, 2023

Conversation

@luizcarloscf
Copy link
Contributor

@luizcarloscf luizcarloscf commented Jan 4, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1206

Link to prove your SVG is correct and up-to-date.

https://www.hashicorp.com/brand#vault
https://www.vaultproject.io/

@luizcarloscf luizcarloscf mentioned this pull request Jan 8, 2023
Merged
6 tasks
@lunatic-fox lunatic-fox added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox requested a review from Snailedlt January 8, 2023 18:53
Snailedlt
Snailedlt requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an alias I want to get in. Once that's added I'll approve ✔️

luizcarloscf and others added 2 commits January 9, 2023 20:13
@luizcarloscf @Snailedlt
Add altname in devicon.json
88d86fb 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@luizcarloscf
Update icons
05a6fac 
- Add newline at the end of each file
- Scale icons to fit in viewbox
Snailedlt
Snailedlt requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as with #1604 :)

lunatic-fox
lunatic-fox reviewed Jan 9, 2023
View reviewed changes
@lunatic-fox lunatic-fox changed the title new icon: vault (original, original-wordmark, plain, plain-wordmark) new icon: vault (original, original-wordmark, plain-wordmark) Jan 27, 2023
lunatic-fox
lunatic-fox approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this great contribution! 🚀

@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR as always! 🎉
Approved! ✔️

@Snailedlt Snailedlt merged commit 8560752 into devicons:develop Jan 27, 2023
@luizcarloscf luizcarloscf deleted the 1206-vault-icons branch May 21, 2023 00:32
@jessestuart jessestuart mentioned this pull request Jun 21, 2023
Open
@jessestuart jessestuart mentioned this pull request Nov 25, 2023
Open
@jessestuart jessestuart mentioned this pull request Dec 20, 2023
Open
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
@jessestuart jessestuart mentioned this pull request Apr 15, 2024
Open
@jessestuart jessestuart mentioned this pull request May 14, 2024
Open
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@luizcarloscf @Snailedlt @lunatic-fox
new icon: vault (original, original-wordmark, plain-wordmark) (devico…
7abaff4 
…ns#1609)

* Add HashiCorp Vault icons. Closes devicons#1206

* Optimize HashiCorp Vault icons

* Add tags and alias in Hashicorp Vault icons

* Add altname in devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Update icons

- Add newline at the end of each file
- Scale icons to fit in viewbox

* Update devicon.json

Co-authored-by: Josélio Júnior <[email protected]>

* Remove extra newline at end file

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees

No one assigned

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luizcarloscf @Snailedlt @lunatic-fox