Skip to content

Conversation

@cyberalien
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Converts text to paths in bootstrap-original-wordmark

This PR closes NONE
Partial fix for #1522

Notes

It reuses path from bootstrap-plain-wordmark that had text converted to path in this commit, so plain and original icons match.

@lunatic-fox
Copy link
Contributor

Made some changes in this pull request:

  • Fix icons for stroke and <text>
  • Change color #59407f to #712cf9, because that's the main color of their site and general color of their original icon version gradient.

Hope that's ok! 🙂

@cyberalien
Copy link
Contributor Author

Of course :)

@lunatic-fox lunatic-fox changed the title update icon: bootstrap (original-wordmark) update icon: bootstrap (original, original-wordmark, plain, plain-wordmark) Nov 20, 2022
@lunatic-fox lunatic-fox added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Nov 20, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox added the feature:icon PR when a new icon is ready to be added to the collection label Nov 20, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ✔️
Thank you for the contribution! 💯

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔️
Thank you for the contribution! 🚀

@Snailedlt Snailedlt merged commit fc34f1b into devicons:develop Nov 20, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…dmark) (devicons#1534)

* fix: convert text to shapes in bootstrap logo

* complement pull request

Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants