Skip to content

new icon: pfsense (original, original-wordmark) #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Snailedlt merged 6 commits into from
Nov 22, 2022
Merged

new icon: pfsense (original, original-wordmark) #1508

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a626589
Add pfsense icon
Nov 14, 2022
29b0d30
Add original wordmark.
Nov 18, 2022
15d67c5
Remove unnecessary attributes of "original-wordmark" and fix "devicon…
lunatic-fox Nov 18, 2022
d493f70
Update icons/pfsense/pfsense-original.svg
yeyeto2788 Nov 21, 2022
7686bd9
Order alphabetically the objects in devicons.json
Nov 21, 2022
3188b93
Update devicon.json
yeyeto2788 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions devicon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9111,5 +9111,35 @@
},
"color": "#2684FF",
"aliases": []
},
{
"name": "pfsense",
Copy link
Copy Markdown
Collaborator

@Snailedlt Snailedlt Nov 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be moved to the correct place in devicon.json, so that the file is alphabetically sorted.

I can see why this is confusing though, since some are not in the correct place. These will be fixed in the future, and an automatic check will be added so you get faster feedback on it too :)

"altnames": [
"pfSense"
],
"tags": [
"network"
],
"versions": {
"svg": [
"original",
"original-wordmark"
],
"font": [
"original",
"original-wordmark"
]
},
"color": "#000000",
Comment thread
Snailedlt marked this conversation as resolved.
Outdated
"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]
}
]
1 change: 1 addition & 0 deletions icons/pfsense/pfsense-original-wordmark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/pfsense/pfsense-original.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.