Skip to content

new icon: githubactions (original,plain) #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 1, 2022
Merged

new icon: githubactions (original,plain) #1463

merged 8 commits into from
Dec 1, 2022

Conversation

@yeyeto2788
Copy link
Contributor

@yeyeto2788 yeyeto2788 commented Oct 17, 2022 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1423

Link to prove your SVG is correct and up-to-date.

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 19, 2022
@Snailedlt Snailedlt self-requested a review October 19, 2022 13:23
Snailedlt
Snailedlt requested changes Oct 29, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main points of this PR are down, just needs some tweaking :)
Good work so far

@Snailedlt Snailedlt changed the title new icon: Github Actions (original,plain) new icon: Githubactions (original,plain) Oct 29, 2022
@Snailedlt Snailedlt changed the title new icon: Githubactions (original,plain) new icon: githubactions (original,plain) Oct 29, 2022
yeyeto2788 and others added 2 commits October 31, 2022 07:39
@yeyeto2788 @Snailedlt
Update devicon.json
37a9620 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@yeyeto2788
Minimize icons
b824bc6
@Snailedlt Snailedlt added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
@Snailedlt Snailedlt requested a review from Panquesito7 October 31, 2022 16:23
Snailedlt
Snailedlt previously approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! ✔️
Thanks for your contribution! 💯

lunatic-fox
lunatic-fox reviewed Dec 1, 2022
View reviewed changes
lunatic-fox
lunatic-fox requested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing some unnecessary attributes.

@lunatic-fox lunatic-fox added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox
lunatic-fox approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes.

Approved! ✔
Thank you for this contribution! 🚀

@lunatic-fox lunatic-fox requested a review from Snailedlt December 1, 2022 10:19
@lunatic-fox lunatic-fox merged commit bfd5078 into devicons:develop Dec 1, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@yeyeto2788 @Snailedlt @lunatic-fox
new icon: githubactions (original,plain) (devicons#1463)
f2edca2 
* Add icon for Github Actions

* Fix paths and ungroup objects.

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>

* Minimize icons

* Update devicon.json

* Update icons/githubactions/githubactions-original.svg

* Update icons/githubactions/githubactions-plain.svg

* Sort alphabetically `githubactions` entry in `devicon.json`

Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees

No one assigned

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yeyeto2788 @Snailedlt @lunatic-fox