Skip to content

Conversation

@ozanuslan
Copy link
Contributor

@ozanuslan ozanuslan commented Oct 6, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #920

Link to prove your SVG is correct and up-to-date.

@Panquesito7 could you take a look? 😊

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'akka' entry: 
- missing key: 'font' in 'versions'.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link

@fmanimashaun fmanimashaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ozanuslan

nice work 👋

@ozanuslan
Copy link
Contributor Author

The system doesn't seem to have registered your approval 😄 Could you re-review it? @fmanimashaun

@ozanuslan ozanuslan requested a review from fmanimashaun October 7, 2022 12:20
fmanimashaun
fmanimashaun previously approved these changes Oct 7, 2022
Copy link

@fmanimashaun fmanimashaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozanuslan

It should be approved once some with access right review and approve!

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Oct 11, 2022
@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Oct 11, 2022
@github-actions

This comment was marked as outdated.

@Panquesito7
Copy link
Member

Panquesito7 commented Oct 11, 2022

Hmm, not sure it looks good when uploaded to IcoMoon. I recommend making a plain versions.
If you need any help, check our Wiki resources or ask on our Discord server. Thanks. 🙂

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but icons used for the font should be mono-colored (see comment below)

@ozanuslan ozanuslan changed the title new icon: akka (original, original-wordmark) new icon: akka (original, original-wordmark, plain, plain-wordmark) Oct 11, 2022
@ozanuslan
Copy link
Contributor Author

ozanuslan commented Oct 11, 2022

What is your opinion on the color of plain versions? There are two 'main' colors of the logo; light blue #15a9ce, and dark blue #0b5567. I think the light blue versions would look better, but the dark blue was more dominant on the original-wordmark so I picked that one.

@ozanuslan ozanuslan requested a review from Snailedlt October 11, 2022 11:17
@Snailedlt
Copy link
Collaborator

What is your opinion on the color of plain versions? There are two 'main' colors of the logo; light blue #15a9ce, and dark blue #0b5567. I think the light blue versions would look better, but the dark blue was more dominant on the original-wordmark so I picked that one.

@ozanuslan
I'm leaning more towards the lighter color, both because it looks better and because it's used more on the main website and in the docs, but it's up to you

@ozanuslan
Copy link
Contributor Author

I agree with you. Changing the color in devicon.json to #15a9ce.

@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 11, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thanks for contributing! 🙇

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks. 🚀

@Panquesito7 Panquesito7 merged commit 35553bc into devicons:develop Oct 11, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1431)

* new icon: akka (original, original-wordmark)

* fix: font in devicon.json

* Apply suggestions from code review

* add akka (plain, plain-wordmark)

* change akka font color to a lighter blue

Co-authored-by: David Leal <[email protected]>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1431)

* new icon: akka (original, original-wordmark)

* fix: font in devicon.json

* Apply suggestions from code review

* add akka (plain, plain-wordmark)

* change akka font color to a lighter blue

Co-authored-by: David Leal <[email protected]>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…evicons#1431)

* new icon: akka (original, original-wordmark)

* fix: font in devicon.json

* Apply suggestions from code review

* add akka (plain, plain-wordmark)

* change akka font color to a lighter blue

Co-authored-by: David Leal <[email protected]>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…evicons#1431)

* new icon: akka (original, original-wordmark)

* fix: font in devicon.json

* Apply suggestions from code review

* add akka (plain, plain-wordmark)

* change akka font color to a lighter blue

Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants