docs: improve contributing deprecation notice #1367
Conversation
...tion notice.
Snailedlt
left a comment
Snailedlt
left a comment
There was a problem hiding this comment.
Looks good, but for some reason there seems to be an empty change at line 506. Any idea what that is?
| | vscode.dev | https://vscode.dev/ | Visual Studio Code in the browser | | ||
| | Iloveimg | https://www.iloveimg.com/resize-image/resize-svg | Resizing SVG's | | ||
| | svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs | | ||
| | svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs | |
There was a problem hiding this comment.
I don't see a change here. Could you point out what exactly changed on this line?
There was a problem hiding this comment.
I'm not sure about that, but I didn't make any changes there.
There was a problem hiding this comment.
it's maybe the line ending / line break, check https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types
There was a problem hiding this comment.
I'll approve once this diff is fixed. Invisible changes always leave me with a bad taste in the mouth
| | vscode.dev | https://vscode.dev/ | Visual Studio Code in the browser | | ||
| | Iloveimg | https://www.iloveimg.com/resize-image/resize-svg | Resizing SVG's | | ||
| | svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs | | ||
| | svgviewer.dev | https://www.svgviewer.dev/ | View, save, and optimize SVGs | |
There was a problem hiding this comment.
I'll approve once this diff is fixed. Invisible changes always leave me with a bad taste in the mouth
|
I found the issue: it seems there was a missing endline in the original file, and on this file, it was automatically added. |
...tion notice.
...tion notice.
...tion notice.
...tion notice.
Things added/changed: