Skip to content

new feature: icons number #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 14, 2023
Merged

new feature: icons number #1267

merged 7 commits into from
Mar 14, 2023

Conversation

@kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 13, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

This PR closes #1218

Notes

Executed locally with python http.server. Feel free to write a review.

Snailedlt
Snailedlt requested changes Jul 14, 2022
View reviewed changes
@kilianpaquier kilianpaquier marked this pull request as draft July 14, 2022 21:06
@kilianpaquier kilianpaquier marked this pull request as ready for review July 15, 2022 08:26
@kilianpaquier kilianpaquier marked this pull request as draft July 22, 2022 09:36
@Snailedlt Snailedlt added the website Website related enhancements label Oct 15, 2022
kilianpaquier
kilianpaquier commented Oct 19, 2022
View reviewed changes
@kilianpaquier kilianpaquier marked this pull request as ready for review October 19, 2022 20:09
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2022
lunatic-fox
lunatic-fox requested changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some changes and here's the preview. 🙂
preview

@Panquesito7
Copy link
Member

Panquesito7 commented Feb 1, 2023

Is this still being updated or?

@Snailedlt
Copy link
Collaborator

Snailedlt commented Feb 1, 2023

Is this still being updated or?

@Panquesito7 Yes, slowly but surely

@Snailedlt Snailedlt added the stale PRs that haven't had any activity for a while and old issues label Mar 4, 2023
@Snailedlt
Copy link
Collaborator

Snailedlt commented Mar 4, 2023 •
edited
Loading

@kilianpaquier let me know if you need any help with this :)
Labeling it as stale since it's been a while since the last update

@kilianpaquier
Copy link
Contributor Author

kilianpaquier commented Mar 6, 2023

@kilianpaquier let me know if you need any help with this :) Labeling it as stale since it's been a while since the last update

Hello, does it still need some things to do ?

@Snailedlt
Copy link
Collaborator

Snailedlt commented Mar 6, 2023

@kilianpaquier let me know if you need any help with this :) Labeling it as stale since it's been a while since the last update

Hello, does it still need some things to do ?

@kilianpaquier Yes, see my last comment in the review comment from lunatic-fox

@kilianpaquier
Copy link
Contributor Author

kilianpaquier commented Mar 6, 2023

@kilianpaquier let me know if you need any help with this :) Labeling it as stale since it's been a while since the last update

Hello, does it still need some things to do ?

@kilianpaquier Yes, see my last comment in the review comment from lunatic-fox

Ok I’m gonna take a look at it tomorrow !

@kilianpaquier
Copy link
Contributor Author

kilianpaquier commented Mar 10, 2023

Hello @Snailedlt, it's done, avg is integer and float in title :). Should we squash the commits ?

@Snailedlt
Copy link
Collaborator

Snailedlt commented Mar 10, 2023

@kilianpaquier
Nice, we can squash merge it, so no need for you to squash :)
I'll review it when I get time

lunatic-fox
lunatic-fox previously approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

lunatic-fox
lunatic-fox reviewed Mar 12, 2023
View reviewed changes
@lunatic-fox
Update docs/index.html
0fa185a 
Co-authored-by: Josélio Júnior <[email protected]>
Panquesito7
Panquesito7 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks! 🚀

Snailedlt
Snailedlt approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but since both @Panquesito7 and @lunatic-fox has approved, I doubt there are any serious issues here. So I'll just approve it ✔️

Thank you again for the great contribution @kilianpaquier , they are a privilege to review!

@lunatic-fox lunatic-fox merged commit bda1033 into devicons:develop Mar 14, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@Snailedlt @lunatic-fox
new feature: icons number (devicons#1267)
5a68d48 
* new feature: icons number - fix devicons#1218

* icon numbers| review suggestions application

Co-authored-by: Snailedlt <[email protected]>

* Change shield link to https://devicon.dev

* add titles and rename logos & icons to icons & icon-versions

* replace = with :

Co-authored-by: Josélio Júnior <[email protected]>

* fixed avg fonts number to integer and added float in title

* Update docs/index.html

Co-authored-by: Josélio Júnior <[email protected]>

---------

Co-authored-by: Kilian PAQUIER <[email protected]>
Co-authored-by: Snailedlt <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Co-authored-by: Josélio Júnior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

Assignees

No one assigned

Labels

enhancement hacktoberfest-accepted Accepted to be counted towards Hacktoberfest stale PRs that haven't had any activity for a while and old issues website Website related enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kilianpaquier @Panquesito7 @Snailedlt @lunatic-fox