-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: sonarqube (original, original-wordmark) #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also, I just read this info : The minimum spacing is equivalent to the height of the capital “S” in SonarQube on all four sides. My original-wordmark icon is not respecting the TOS with our current standards. We must implement this issue #1209 before merging. |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
1 similar comment
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
|
@kilian-paquier I don't believe we have to follow that since it goes under fair use.
https://www.nolo.com/legal-encyclopedia/when-you-need-permission-use-trademarks.html |
Hello @Snailedlt, if you say so ! But shouldn't we also follow the rules given by sonarqube on the usage of the logos ? Link, SVG dimensions ? |
|
@kilian-paquier imo that's up to the people who use the logo in their product, and not us. Just my opinion though, so might be wrong |
|
Viewbox should be 0 0 128 128 for all icons |
|
Hello @Snailedlt, yep, that's why it's a draft ahah. I'll adapt the wordmark when I have time 🙂 |
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM✔️
Another great addition! 💯
Thanks for your contribution!
* new icon: sonarqube (original, original-wordmark) * sonarqube| use official logo and icon spacing * Update icons/sonarqube/sonarqube-original-wordmark.svg * Update icons/sonarqube/sonarqube-original-wordmark.svg
* new icon: sonarqube (original, original-wordmark) * sonarqube| use official logo and icon spacing * Update icons/sonarqube/sonarqube-original-wordmark.svg * Update icons/sonarqube/sonarqube-original-wordmark.svg
* new icon: sonarqube (original, original-wordmark) * sonarqube| use official logo and icon spacing * Update icons/sonarqube/sonarqube-original-wordmark.svg * Update icons/sonarqube/sonarqube-original-wordmark.svg
* new icon: sonarqube (original, original-wordmark) * sonarqube| use official logo and icon spacing * Update icons/sonarqube/sonarqube-original-wordmark.svg * Update icons/sonarqube/sonarqube-original-wordmark.svg
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes #1174
Link to prove your SVG is correct and up-to-date.
https://www.sonarqube.org/logos/
NB :
Probably a PR we won't be merging soon.