Skip to content

Conversation

@kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 2, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1174

Link to prove your SVG is correct and up-to-date.

https://www.sonarqube.org/logos/

NB :

  • As stated in the issue [FEATURE REQUEST] Add links to TOS where applicable #1210, SonarQube TOS state that the icons must have a hyperlink to sonarqube website.
  • I also made sure to take the official branding SVGs.
  • Also, for anyone who wants to use the sonarqube icon / font, especially the non-wordmark icon, the logo must always be visually associated with the name of the brand.

Probably a PR we won't be merging soon.

@kilianpaquier
Copy link
Contributor Author

kilianpaquier commented Jul 2, 2022

Also, I just read this info : The minimum spacing is equivalent to the height of the capital “S” in SonarQube on all four sides. My original-wordmark icon is not respecting the TOS with our current standards.

We must implement this issue #1209 before merging.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'sonarqube-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'sonarqube-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'sonarqube-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt
Copy link
Collaborator

@kilian-paquier I don't believe we have to follow that since it goes under fair use.

By law, you need not request permission to use a trademark belonging to another if it is for an editorial or informational use.

https://www.nolo.com/legal-encyclopedia/when-you-need-permission-use-trademarks.html

@kilianpaquier
Copy link
Contributor Author

@kilian-paquier I don't believe we have to follow that since it goes under fair use.

By law, you need not request permission to use a trademark belonging to another if it is for an editorial or informational use.

https://www.nolo.com/legal-encyclopedia/when-you-need-permission-use-trademarks.html

Hello @Snailedlt, if you say so ! But shouldn't we also follow the rules given by sonarqube on the usage of the logos ? Link, SVG dimensions ?

@Snailedlt
Copy link
Collaborator

@kilian-paquier imo that's up to the people who use the logo in their product, and not us. Just my opinion though, so might be wrong

@Snailedlt
Copy link
Collaborator

Viewbox should be 0 0 128 128 for all icons

@kilianpaquier
Copy link
Contributor Author

Hello @Snailedlt, yep, that's why it's a draft ahah. I'll adapt the wordmark when I have time 🙂

@kilianpaquier kilianpaquier marked this pull request as ready for review July 15, 2022 13:53
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✔️
Another great addition! 💯
Thanks for your contribution!

@Snailedlt Snailedlt merged commit 7ccca6e into devicons:develop Jul 24, 2022
@kilianpaquier kilianpaquier deleted the sonarqube branch July 24, 2022 09:09
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: sonarqube (original, original-wordmark)

* sonarqube| use official logo and icon spacing

* Update icons/sonarqube/sonarqube-original-wordmark.svg

* Update icons/sonarqube/sonarqube-original-wordmark.svg
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: sonarqube (original, original-wordmark)

* sonarqube| use official logo and icon spacing

* Update icons/sonarqube/sonarqube-original-wordmark.svg

* Update icons/sonarqube/sonarqube-original-wordmark.svg
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* new icon: sonarqube (original, original-wordmark)

* sonarqube| use official logo and icon spacing

* Update icons/sonarqube/sonarqube-original-wordmark.svg

* Update icons/sonarqube/sonarqube-original-wordmark.svg
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* new icon: sonarqube (original, original-wordmark)

* sonarqube| use official logo and icon spacing

* Update icons/sonarqube/sonarqube-original-wordmark.svg

* Update icons/sonarqube/sonarqube-original-wordmark.svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants