Skip to content

Fix check icon not running for update icon pr #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix check icon not running for update icon pr #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/icomoon_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def main():

print("Task completed.")
except TimeoutException as e:
util.exit_with_err("Selenium Time Out Error: \n" + str(e))
util.exit_with_err(Exception("Selenium Time Out Error: \n" + str(e)))
except Exception as e:
util.exit_with_err(e)
finally:
Expand Down Expand Up @@ -95,7 +95,7 @@ def get_icons_for_building(icomoon_json_path: str, devicon_json_path: str, token
return new_icons


def optimize_svgs(new_icons: List[str], icons_folder_path: str):
def optimize_svgs(new_icons: List[dict], icons_folder_path: str):
"""
Optimize the newly added svgs. This is done in batches
since the command line has a limit on characters allowed.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check_icon_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
check:
name: Check the `devicon.json` and the SVGs' quality
runs-on: ubuntu-18.04
if: startsWith(github.event.pull_request.title, 'new icon') # only checks icon PR
if: startsWith(github.event.pull_request.title, 'new icon') || startsWith(github.event.pull_request.title, 'update icon') # only checks icon PR
steps:
- uses: actions/checkout@v2

Expand Down