fix: stage CHANGELOG.md in semantic-release build_command#301
fix: stage CHANGELOG.md in semantic-release build_command#301ichoosetoaccept merged 1 commit intomainfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
Greptile SummaryThis PR fixes a missing Confidence Score: 5/5Safe to merge — targeted one-line fix in both configs with no side effects Both changes are minimal and correct: CHANGELOG.md is written by semantic-release before build_command runs, so staging it here guarantees it lands in the release commit. The fix is applied symmetrically to the repo's own config and the Jinja template. No logic, ordering, or conditional issues found. No files require special attention Important Files Changed
Sequence DiagramsequenceDiagram
participant SR as semantic-release
participant FS as Filesystem
participant Git as Git index
SR->>FS: Bump version in pyproject.toml
SR->>FS: Write/update CHANGELOG.md
SR->>SR: Run build_command
SR->>SR: uv lock --upgrade-package $PACKAGE_NAME
SR->>FS: Updates uv.lock
SR->>Git: git add uv.lock CHANGELOG.md
Note over Git: CHANGELOG.md now staged (this PR's fix)
SR->>FS: uv build (generated projects only)
SR->>Git: Commit release (all staged files included)
Reviews (1): Last reviewed commit: "fix: stage CHANGELOG.md in semantic-rele..." | Re-trigger Greptile |
Closes DOT-393
Summary
CHANGELOG.mdtogit addin the semantic-releasebuild_commandin bothpyproject.tomlandproject/pyproject.toml.jinjaProblem
build_commandonly stageduv.lock, soCHANGELOG.mdwas never included in the release commit despitemode = "update"being configured. GitHub Releases were unaffected (generated separately), but the committed CHANGELOG.md stayed empty across releases.