remove pin on pip version #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This doesn't work with the pinned desimodel==0.19.3 which was before desimodel pyproject.toml and setup.cfg were added. This highlights that we probably have a bunch of tags that can't be installed with pip 25.3. To be continued... |
Member
|
It looks like you didn't add |
Member
|
@sbailey, I think this OK to merge as-is if you would rather address issues like pyproject.toml separately. |
Contributor
Author
|
Yes, let's address pyproject.toml in a separate PR. Summarizing the state of installing other desi packages that were tagged before adding pyproject.toml + setup.cfg — either
Those workaround don't require any changes to desispec itself, but they impact how we install packages for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desihub/desitarget#864 fixed the underlying incompatibility that previously required us to pin pip==25.2 . This PR removes that pinned version. This may trigger similar issues in other packages for followup.