double counting files in dailychecks

[abrodze]

A handful of times the past week, two tiles were observed in one night where the TILEID of one was fully contained in the other (all bright1b-dark combos). The check_redshifts.sh script only searches for "TILEID" when counting files, so it double-counts the longer TILEID under the shorter one, for example https://data.desi.lbl.gov/desi/spectro/redux/daily/run/scripts/qa/daily_checks/nightof_20260117.log

This should be fixed by changing the search to "-${TILEID}-"

[sbailey]

Thanks for catching this. I think we need to edit /global/cfs/cdirs/desi/spectro/redux/daily/run/scripts/qa/check_redshifts.sh to change line 89 from

    PERTILEOUTPUT=$(echo "${TILEOUTPUT}" | grep ${TIL})e

to

    PERTILEOUTPUT=$(echo "${TILEOUTPUT}" | grep "\-${TIL}\-")

Note the use of backslash-escaping the hyphen "-" symbol; otherwise grep gets confused.
Also: the current code has an extraneous but harmless "e" at the end of that line. I think that is a leftover editing typo that doesn't carry meaning.

tested with extracting various commands from check_redshifts.sh:

cd /global/cfs/cdirs/desi/spectro/redux/daily/tiles/cumulative
RAWTILELIST="123205 3205"
TEMPORARYNIGHT=20260117
TILEOUTPUT=$(for ITERTILEID in ${RAWTILELIST}; do ls ./${ITERTILEID}/${TEMPORARYNIGHT}/*.* 2>/dev/null; done)
TIL=3205

# incorrectly nspec=20
PERTILEOUTPUT=$(echo "${TILEOUTPUT}" | grep ${TIL})e
nspec=$(echo "${PERTILEOUTPUT}" | grep spectra | wc -l)
echo $nspec

# correctly nspec=10
PERTILEOUTPUT=$(echo "${TILEOUTPUT}" | grep "\-${TIL}\-")
nspec=$(echo "${PERTILEOUTPUT}" | grep spectra | wc -l)
echo $nspec

@abrodze please double check me, and if you agree go ahead and make that edit. Thanks.

[abrodze]

I confirmed this change works on 20260116, when tiles 4795 and 44795 were observed. Implemented and closing issue.