Skip to content

fix(color-contrast): do not run on elements with font-size: 0 #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

fix(color-contrast): do not run on elements with font-size: 0 #4822

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e20ea
fix bug when testing vscode plugin
straker Jul 9, 2025
634a6a1
fix
straker Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/rules/color-contrast-matches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ function colorContrastMatches(node, virtualNode) {
return false;
}

if (virtualNode.getComputedStylePropertyValue('font-size') === '0px') {
return false;
}

const range = document.createRange();
const childNodes = virtualNode.children;
for (let index = 0; index < childNodes.length; index++) {
Expand Down
7 changes: 7 additions & 0 deletions test/rule-matches/color-contrast-matches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,13 @@ describe('color-contrast-matches', function () {
assert.isFalse(rule.matches(target, axe.utils.getNodeFromTree(target)));
});

it('should not match text with font-size: 0', () => {
fixture.innerHTML = '<div style="font-size: 0">hi</div>';
const target = fixture.querySelector('div');
axe.testUtils.flatTreeSetup(fixture);
assert.isFalse(rule.matches(target, axe.utils.getNodeFromTree(target)));
});

if (shadowSupport) {
it('should match a descendant of an element across a shadow boundary', function () {
fixture.innerHTML =
Expand Down
Loading