test: rename generic test titles #4453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
straker
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
WilcoFiers
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests failed while in-development of #4452 and it really confused me. Based on how the title is written, I initially thought that it was making sure that
.selector(etc.) for the DqElement prototype function was never called. But what it's really making sure is that the.selector(etc.) property is not called for the one node.The reason that distinction matters is because
processAggregatecallsnodeSerializerwhich in turn calls thetoJSONmethod of a DqElement, which calls the.selector(etc.) property. So it would be impossible to never call the DqElement properties.