feat(td-headers-attr): report headers attribute referencing other <td> elements as unsupported #4589

engineerklimov · 2024-09-26T10:48:46Z

Fix for the header attribute check. The check will report cells that references other <td> elements. Added unit and integrations tests as requested in corresponding issue.

Closes: #3987

engineerklimov · 2024-10-16T18:33:21Z

Please, let me know if there are any changes needed. Thanks!
@WilcoFiers and @straker for vis.

WilcoFiers · 2024-10-23T16:40:41Z

@engineerklimov Heyya, apologies about the delays. Lots to do. I'll try to get to it within the week.

engineerklimov · 2024-10-23T17:29:21Z

Appreciate your response, Sir
Looking forward to the review

WilcoFiers

There are some scenarios the original ticket didn't consider that I feel we need to test before we can start failing this. Let me know if you have the necessary software to do this testing, otherwise we'll see what we can do on our end. At the very least we'll need to test this with NVDA + Firefox and JAWS + Chrome. Normally we'd also want VO + Safari but since it doesn't support the headers attribute anyway there's no point in that.

lib/checks/tables/td-headers-attr-evaluate.js

test/checks/tables/td-headers-attr.js

test/integration/rules/td-headers-attr/td-headers-attr.html

lib/checks/tables/td-headers-attr.json

lib/checks/tables/td-headers-attr-evaluate.js

test/integration/rules/td-headers-attr/td-headers-attr.html

test/checks/tables/td-headers-attr.js

lib/checks/tables/td-headers-attr-evaluate.js

WilcoFiers · 2024-11-01T11:23:31Z

I'm going to change this PR title to "feat". This PR makes the rule stricter, we can't put that in a patch release.

engineerklimov · 2024-11-01T17:18:53Z

@WilcoFiers I did all changes, the only thing left is locales updates. Can you check error messages? If they are fine i will update all translations.

WilcoFiers

LGTM. Let me ask a colleague for a final OK, since I wrote part of the solve.

dbjorge

Thanks for the contribution! This is looking good overall, just noticed a few more bits to clean up

lib/checks/tables/td-headers-attr-evaluate.js

lib/checks/tables/td-headers-attr.json

engineerklimov · 2024-11-12T19:12:06Z

locales/ru.json

      "pass": "Атрибут headers используется исключительно для ссылки на другие ячейки таблицы",
      "incomplete": "Атрибут headers пуст",
-      "fail": "Атрибут headers не используется исключительно для ссылки на другие ячейки таблицы"
+      "fail": {


I tried to update locales. I found that all locales are quite outdated. Not sure that this change is good place to bring all locales up to date. So i updated only "ru" which i contributed recently. Not sure what is contribution policy here.

lib/rules/td-headers-attr.json

dbjorge

It looks like fmt_check is still showing 1 error to resolve, + it'd be good to do an npm run build to re-generate /locales/_template.json to match the most recent rule text update.

Other than those, this looks good to me!

engineerklimov · 2024-11-15T15:03:33Z

It looks like fmt_check is still showing 1 error to resolve, + it'd be good to do an npm run build to re-generate /locales/_template.json to match the most recent rule text update.

Other than those, this looks good to me!

I did updates you requested, there is problem with @WilcoFiers test case with wrong closing tag. Prettier shows error here somehow line ignore not working.

So i updated .prettierignore, let me know if there is better way to fix it.

test/integration/rules/td-headers-attr/td-headers-attr.html

engineerklimov · 2024-11-19T14:42:22Z

I pursue your approvals guys @WilcoFiers @dbjorge @straker 🙂

dbjorge

LGTM! Reviewed for security (besides the commit I just made in
04ff14d )

dbjorge · 2024-11-19T19:03:19Z

(@WilcoFiers , once you've done the security review for my editorial commit, feel free to merge)

WilcoFiers · 2024-11-19T20:11:05Z

For the bookx: Reviewed for security.

done

## [4.11.0](v4.10.3...v4.11.0) (2025-10-07) ### Features - add RGAA tags to rules ([#4862](#4862)) ([53a925a](53a925a)) - **aria-prohibited-attr:** add support for fallback roles ([#4325](#4325)) ([62a19a9](62a19a9)) - **axe.d.ts:** add nodeSerializer typings ([#4551](#4551)) ([a2f3a48](a2f3a48)), closes [#4093](#4093) - **DqElement:** deprecate fromFrame function ([#4881](#4881)) ([374c376](374c376)), closes [#4093](#4093) - **DqElement:** Truncate large `html` strings when the element has a large outerHTML string ([#4796](#4796)) ([404a4fb](404a4fb)), closes [#4544](#4544) - **get-xpath:** return proper relative selector for id ([#4846](#4846)) ([1035f9e](1035f9e)), closes [#4845](#4845) - **i18n:** Add Portugal Portuguese translation ([#4725](#4725)) ([5b6a65a](5b6a65a)) - incomplete with node on which an error occurred ([#4863](#4863)) ([32ed8da](32ed8da)) - **locale:** Added ru locale ([#4565](#4565)) ([067b01d](067b01d)) - **tap:** some best practice rules map to RGAA ([#4895](#4895)) ([bc33f4c](bc33f4c)) - **td-headers-attr:** report headers attribute referencing other <td> elements as unsupported ([#4589](#4589)) ([ec7c6c8](ec7c6c8)), closes [#3987](#3987) ### Bug Fixes - **aria-allowed-role:** add form to allowed roles of form element ([#4588](#4588)) ([8aa47ac](8aa47ac)), closes [/github.com/dequelabs/axe-core/blob/develop/lib/standards/html-elms.js#L264](https://github.com/dequelabs//github.com/dequelabs/axe-core/blob/develop/lib/standards/html-elms.js/issues/L264) - **aria-allowed-role:** Add math to allowed roles for img element ([#4658](#4658)) ([95b6c18](95b6c18)), closes [#4657](#4657) - **autocomplete-valid :** Ignore readonly autocomplete field ([#4721](#4721)) ([491f4ec](491f4ec)), closes [#4708](#4708) - **autocomplete-valid:** treat values "xon" and "xoff" as non-WCAG-violations ([#4878](#4878)) ([52bc611](52bc611)), closes [#4877](#4877) - **axe.d.ts:** add typings for preload options object ([#4543](#4543)) ([cfd2974](cfd2974)) - **button-name,input-button-name,input-img-alt:** allow label to give accessible name ([#4607](#4607)) ([a9710d7](a9710d7)), closes [#4472](#4472) [#3696](#3696) [#3696](#3696) - **captions:** fix grammar in captions check incomplete message ([#4661](#4661)) ([11de515](11de515)) - **color-contrast:** do not run on elements with font-size: 0 ([#4822](#4822)) ([d77c885](d77c885)), closes [#4820](#4820) - consistently parse tabindex, following HTML 5 spec ([#4637](#4637)) ([645a850](645a850)), closes [#4632](#4632) - **core:** measure perf for async checks ([#4609](#4609)) ([7e9bacf](7e9bacf)) - fix grammar when using "alternative text" in a sentence ([#4811](#4811)) ([237a586](237a586)), closes [#4394](#4394) - **get-ancestry:** add nth-child selector for multiple siblings of shadow root ([#4606](#4606)) ([1cdd6c3](1cdd6c3)), closes [#4563](#4563) - **get-ancestry:** don't error when there is no parent ([#4617](#4617)) ([a005703](a005703)) - **locale:** fix typos in japanese (ja) locale ([#4856](#4856)) ([3462cc5](3462cc5)) - **locale:** fixed typos in german (DE) locale ([#4631](#4631)) ([b7736de](b7736de)) - **locale:** proofread and updated de.json ([#4643](#4643)) ([8060ada](8060ada)) - **meta-viewport:** lower impact to moderate ([#4887](#4887)) ([2f32aa5](2f32aa5)), closes [#4714](#4714) - **no-autoplay-audio:** don't timeout for preload=none media elements ([#4684](#4684)) ([cdc871e](cdc871e)) - **performanceTimer:** throwing in axe catch clause ([#4852](#4852)) ([a4ade04](a4ade04)), closes [/github.com/dequelabs/axe-core/blob/e7dae4ec48cbfef74de9f833fdcfb178c1002985/lib/core/base/rule.js#L297-L300](https://github.com/dequelabs//github.com/dequelabs/axe-core/blob/e7dae4ec48cbfef74de9f833fdcfb178c1002985/lib/core/base/rule.js/issues/L297-L300) - **performanceTimer:** work in frames ([#4834](#4834)) ([d7dfebc](d7dfebc)) - **rules:** Change "alternate text" to "alternative text" ([#4582](#4582)) ([b03ada3](b03ada3)) - **target-size:** do not treat focusable tabpanels as targets ([#4702](#4702)) ([60d11f2](60d11f2)), closes [#4421](#4421) [#4701](#4701) - **type:** correct RuleError type ([#4893](#4893)) ([d1aa8e2](d1aa8e2)) - **types:** correct raw types ([#4903](#4903)) ([3eade11](3eade11)) This PR was opened by a robot 🤖 🎉

engineerklimov added 2 commits September 11, 2024 17:09

td ref test

6942d2a

filter td elements

10e5844

engineerklimov marked this pull request as ready for review September 26, 2024 10:51

engineerklimov requested a review from a team as a code owner September 26, 2024 10:51

Merge branch 'develop' into 3987-headers-attr-ref

b2dd10e

engineerklimov mentioned this pull request Oct 2, 2024

Report headers attribute referencing other <td> elements as unsupported #3987

Closed

WilcoFiers requested changes Oct 28, 2024

View reviewed changes

engineerklimov and others added 4 commits October 29, 2024 17:15

reduce looping, exclude cells with role atts

7942fde

adjust error message

23fdbce

Merge branch 'dequelabs:develop' into 3987-headers-attr-ref

1a1dc0e

update locale template

de1c148

engineerklimov commented Oct 30, 2024

View reviewed changes

lib/checks/tables/td-headers-attr.json Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

engineerklimov requested a review from WilcoFiers October 31, 2024 09:49

WilcoFiers previously requested changes Oct 31, 2024

View reviewed changes

WilcoFiers changed the title ~~fix(td-ref-attr): report headers attribute referencing other <td> elements as unsupported~~ feat(td-ref-attr): report headers attribute referencing other <td> elements as unsupported Nov 1, 2024

engineerklimov added 5 commits November 1, 2024 15:24

collect errors by keys

566c45b

update tests

ffb2c4d

update test ids

57bd7c4

update locales template

4044fd9

fix test, and func

39546fd

engineerklimov requested review from WilcoFiers and straker November 4, 2024 10:58

WilcoFiers reviewed Nov 8, 2024

View reviewed changes

WilcoFiers self-requested a review November 8, 2024 13:01

dbjorge requested changes Nov 8, 2024

View reviewed changes

lib/checks/tables/td-headers-attr-evaluate.js Show resolved Hide resolved

lib/checks/tables/td-headers-attr.json Outdated Show resolved Hide resolved

lib/checks/tables/td-headers-attr.json Show resolved Hide resolved

engineerklimov added 2 commits November 12, 2024 13:09

typo

cacbb30

adjust messages

effb955

engineerklimov requested a review from dbjorge November 12, 2024 18:33

engineerklimov added 2 commits November 12, 2024 20:56

update locale template

39fb1b1

fi ru locale

9cac9ee

engineerklimov commented Nov 12, 2024

View reviewed changes

lib/rules/td-headers-attr.json Outdated Show resolved Hide resolved

engineerklimov added 2 commits November 12, 2024 22:19

upd docs

1722053

replace badcells arr with set

5d1440e

dbjorge requested changes Nov 12, 2024

View reviewed changes

lib/rules/td-headers-attr.json Outdated Show resolved Hide resolved

update rules text

e467de5

engineerklimov requested a review from dbjorge November 14, 2024 13:25

dbjorge changed the title ~~feat(td-ref-attr): report headers attribute referencing other <td> elements as unsupported~~ feat(td-headers-attr): report headers attribute referencing other <td> elements as unsupported Nov 15, 2024

dbjorge requested changes Nov 15, 2024

View reviewed changes

fix linter, run build

4897ecc

dbjorge requested changes Nov 15, 2024

View reviewed changes

test/integration/rules/td-headers-attr/td-headers-attr.html Outdated Show resolved Hide resolved

fix type once again

379edb8

engineerklimov requested a review from dbjorge November 19, 2024 14:38

remove stray period from help text

04ff14d

dbjorge approved these changes Nov 19, 2024

View reviewed changes

WilcoFiers merged commit ec7c6c8 into dequelabs:develop Nov 19, 2024
21 of 22 checks passed

attest-team-ci mentioned this pull request Oct 7, 2025

chore(release): v4.11.0 #4904

Merged

feat(td-headers-attr): report headers attribute referencing other <td> elements as unsupported #4589

feat(td-headers-attr): report headers attribute referencing other <td> elements as unsupported #4589

Uh oh!

Conversation

engineerklimov commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engineerklimov commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WilcoFiers commented Oct 23, 2024

Uh oh!

engineerklimov commented Oct 23, 2024

Uh oh!

WilcoFiers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WilcoFiers commented Nov 1, 2024

Uh oh!

engineerklimov commented Nov 1, 2024

Uh oh!

WilcoFiers left a comment

Choose a reason for hiding this comment

Uh oh!

dbjorge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

engineerklimov Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dbjorge left a comment

Choose a reason for hiding this comment

Uh oh!

engineerklimov commented Nov 15, 2024

Uh oh!

Uh oh!

engineerklimov commented Nov 19, 2024

Uh oh!

dbjorge left a comment

Choose a reason for hiding this comment

Uh oh!

dbjorge commented Nov 19, 2024

Uh oh!

WilcoFiers commented Nov 19, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

engineerklimov commented Sep 26, 2024 •

edited

Loading

engineerklimov commented Oct 16, 2024 •

edited

Loading