Skip to content

Commit 52bc611

Browse files
authored
fix(autocomplete-valid): treat values "xon" and "xoff" as non-WCAG-violations (#4878)
Similar to #3188. Resolves a false positive report from an auditor customer. Closes: #4877
1 parent b93ab81 commit 52bc611

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

lib/checks/forms/autocomplete-valid.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
"disabled",
1818
"enabled",
1919
"undefined",
20-
"null"
20+
"null",
21+
"xoff",
22+
"xon"
2123
],
2224
"ignoredValues": ["text", "pronouns", "gender", "message", "content"]
2325
}

test/integration/rules/autocomplete-valid/autocomplete-valid.html

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,12 +164,14 @@
164164
<input autocomplete="enabled" id="pass88" />
165165
<input autocomplete="undefined" id="pass89" />
166166
<input autocomplete="null" id="pass90" />
167+
<input autocomplete="xon" id="pass91" />
168+
<input autocomplete="xoff" id="pass92" />
167169

168170
<!-- Webauthn tokens -->
169-
<input autocomplete="email webauthn" id="pass91" />
170-
<input autocomplete="section-foo email webauthn" id="pass92" />
171-
<input autocomplete="section-foo work email webauthn" id="pass93" />
172-
<input autocomplete="section-foo billing work email webauthn" id="pass94" />
171+
<input autocomplete="email webauthn" id="pass93" />
172+
<input autocomplete="section-foo email webauthn" id="pass94" />
173+
<input autocomplete="section-foo work email webauthn" id="pass95" />
174+
<input autocomplete="section-foo billing work email webauthn" id="pass96" />
173175

174176
<!-- Incomplete, ignored values -->
175177
<input autocomplete="text" id="incomplete1" />

test/integration/rules/autocomplete-valid/autocomplete-valid.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@
103103
["#pass91"],
104104
["#pass92"],
105105
["#pass93"],
106-
["#pass94"]
106+
["#pass94"],
107+
["#pass95"],
108+
["#pass96"]
107109
]
108110
}

0 commit comments

Comments
 (0)