This repository was archived by the owner on Jan 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
compile with ghc 6.12.3 #5
Open
markwright
wants to merge
1
commit into
depressed-pho:master
Choose a base branch
from
markwright:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,11 +50,12 @@ import qualified Data.ByteString.Char8 as B8 | |
| import qualified Data.ByteString.Lazy.Char8 as L8 | ||
| import qualified Data.ByteString.Lazy.Internal as L8 | ||
| import Control.Applicative ((<$>)) | ||
| import Control.Exception (mask, mask_, bracket_, onException) | ||
| import Foreign.C.Types (CChar) | ||
| #if __GLASGOW_HASKELL__ >= 703 | ||
| import Control.Exception (mask, mask_, bracket_, onException) | ||
| import Foreign.C.Types (CInt(..), CUInt(..), CSize(..)) | ||
| #else | ||
| import Control.Exception (block, unblock, bracket_, onException) | ||
| import Foreign.C.Types (CInt, CUInt, CSize) | ||
| #endif | ||
| import Foreign.Ptr (Ptr, castPtr, FunPtr) | ||
|
|
@@ -104,10 +105,17 @@ foreign import ccall unsafe "HsOpenSSL_EVP_CIPHER_CTX_block_size" | |
| newCipherCtx :: IO CipherCtx | ||
| newCipherCtx = do | ||
| ctx <- mallocForeignPtrBytes (#size EVP_CIPHER_CTX) | ||
| #if __GLASGOW_HASKELL__ >= 703 | ||
| mask_ $ do | ||
| withForeignPtr ctx _cipher_ctx_init | ||
| addForeignPtrFinalizer _cipher_ctx_cleanup ctx | ||
| return $ CipherCtx ctx | ||
| #else | ||
| block $ do | ||
| withForeignPtr ctx _cipher_ctx_init | ||
| addForeignPtrFinalizer _cipher_ctx_cleanup ctx | ||
| unblock $ return $ CipherCtx ctx | ||
| #endif | ||
|
|
||
| withCipherCtxPtr :: CipherCtx -> (Ptr EVP_CIPHER_CTX -> IO a) -> IO a | ||
| withCipherCtxPtr (CipherCtx ctx) = withForeignPtr ctx | ||
|
|
@@ -186,10 +194,17 @@ foreign import ccall unsafe "&EVP_MD_CTX_cleanup" | |
| newDigestCtx :: IO DigestCtx | ||
| newDigestCtx = do | ||
| ctx <- mallocForeignPtrBytes (#size EVP_MD_CTX) | ||
| #if __GLASGOW_HASKELL__ >= 703 | ||
| mask_ $ do | ||
| withForeignPtr ctx _md_ctx_init | ||
| addForeignPtrFinalizer _md_ctx_cleanup ctx | ||
| return $ DigestCtx ctx | ||
| #else | ||
| block $ do | ||
| withForeignPtr ctx _md_ctx_init | ||
| addForeignPtrFinalizer _md_ctx_cleanup ctx | ||
| unblock $ return $ DigestCtx ctx | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likewise. return $ DigestCtx ctx |
||
| #endif | ||
|
|
||
| withDigestCtxPtr :: DigestCtx -> (Ptr EVP_MD_CTX -> IO a) -> IO a | ||
| withDigestCtxPtr (DigestCtx ctx) = withForeignPtr ctx | ||
|
|
@@ -286,10 +301,17 @@ wrapPKeyPtr :: Ptr EVP_PKEY -> IO VaguePKey | |
| wrapPKeyPtr = fmap VaguePKey . newForeignPtr _pkey_free | ||
|
|
||
| createPKey :: (Ptr EVP_PKEY -> IO a) -> IO VaguePKey | ||
| #if __GLASGOW_HASKELL__ >= 703 | ||
| createPKey f = mask $ \restore -> do | ||
| ptr <- _pkey_new >>= failIfNull | ||
| (restore $ f ptr >> return ()) `onException` _pkey_free' ptr | ||
| wrapPKeyPtr ptr | ||
| #else | ||
| createPKey f = block $ do | ||
| ptr <- _pkey_new >>= failIfNull | ||
| (f ptr >> return ()) `onException` _pkey_free' ptr | ||
| unblock $ wrapPKeyPtr ptr | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be something like this? createPKey f = block $ do
ptr <- _pkey_new >>= failIfNull
(unblock $ f ptr >> return ()) `onException` _pkey_free' ptr
wrapPKeyPtr ptr |
||
| #endif | ||
|
|
||
| withPKeyPtr :: VaguePKey -> (Ptr EVP_PKEY -> IO a) -> IO a | ||
| withPKeyPtr (VaguePKey pkey) = withForeignPtr pkey | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need 'unblock' in the last line?