Remove unused sortedHeaderKeys function#40
Merged
JamieMagee merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
The sortedHeaderKeys function in logging.go was flagged by golangci-lint's unused checker. It's not called anywhere, so remove it along with the sort import it was the sole consumer of.
jpinz
approved these changes
Feb 10, 2026
There was a problem hiding this comment.
Pull request overview
Removes an unused helper from the proxy’s main logging.go file to satisfy golangci-lint’s unused checker, keeping the logging code free of dead code and unnecessary imports.
Changes:
- Removed the unused
sortedHeaderKeysfunction. - Dropped the now-unused
sortimport fromlogging.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sortedHeaderKeysinlogging.goisn't called anywhere. golangci-lint'sunusedchecker flags it. This removes the function and drops thesortimport, which nothing else in the file needs.