Fix noctx lint warnings#38
Merged
JamieMagee merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes noctx linter warnings by replacing deprecated functions with their context-aware equivalents. The changes update http.NewRequest to http.NewRequestWithContext and net.Listen to net.ListenConfig{}.Listen, both using context.Background() which is appropriate for test code and initialization code where no upstream context exists.
Changes:
- Replace deprecated
http.NewRequestwithhttp.NewRequestWithContext(context.Background(), ...)in tests and startup code - Replace deprecated
net.Listenwithnet.ListenConfig{}.Listen(context.Background(), ...)in test setup - Add
contextimport to all modified files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proxy_test.go | Updated test helpers to use context-aware HTTP request and network listen functions |
| logging_test.go | Updated test case to use http.NewRequestWithContext |
| internal/handlers/nuget_feed.go | Updated NuGet feed initialization code to use context-aware HTTP requests |
| internal/handlers/git_server_test.go | Updated multiple test cases to use http.NewRequestWithContext |
truggeri
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
http.NewRequestwithhttp.NewRequestWithContextandnet.Listenwithnet.ListenConfig{}.Listento satisfy the noctx linter.The startup code in
nuget_feed.gousescontext.Background()since there's no incoming request context to propagate. Test files do the same.