Skip to content

strip user without password #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2023
Merged

strip user without password #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e312a38
strip user without password
jakecoffman Mar 31, 2023
86552a2
add more info
jakecoffman Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ func Scrub(argument string) string {
u, err := url.ParseRequestURI(argument)
if err == nil && u.Host != "" && contains(allowedSchemes, u.Scheme) {
u.Scheme = "https"
// clear the user if there is no password, since it's common to use [email protected]
if _, isSet := u.User.Password(); !isSet {
u.User = nil
}
return u.String()
}
if scpUrl.MatchString(argument) {
Expand All @@ -109,7 +113,11 @@ func Scrub(argument string) string {
// host changed, possible attack
return argument
}
return newUrl
// clear the user if there is no password, since it's common to use [email protected]
if _, isSet := u.User.Password(); !isSet {
u.User = nil
}
return u.String()
}
return argument
}
Expand Down
8 changes: 6 additions & 2 deletions main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,15 @@ func TestScrub(t *testing.T) {
},
{
input: "[email protected]:dependabot/git-https-shim",
expected: "https://[email protected]/dependabot/git-https-shim",
expected: "https://github.com/dependabot/git-https-shim",
},
{
input: "ssh://user:[email protected]/dependabot/git-https-shim",
expected: "https://user:[email protected]/dependabot/git-https-shim",
},
{
input: "ssh://[email protected]/dependabot/git-https-shim",
expected: "https://git@github.com/dependabot/git-https-shim",
expected: "https://github.com/dependabot/git-https-shim",
},
{
input: "ssh://github.com/dependabot/git-https-shim",
Expand Down