added support for all authentication methods of composer#12946
added support for all authentication methods of composer#12946FalkoHilbert wants to merge 1 commit intodependabot:mainfrom
Conversation
|
Note: When reviewing this PR, please keep in mind that the approach shifts credential handling to the proxy rather than |
c6366a4 to
6017411
Compare
|
Hi @robaiken is there anything else I can do to support the completion of the pull request? |
|
Hi @robaiken, Could you give me an update? Unfortunately, I haven't received any further feedback here, so I don't have any information about what else I can do to enable us to merge the feature. |
|
@FalkoHilbert Thanks for the suggestion! Unfortunately, this approach won't work because it would require changes to the proxy service that sits between Dependabot and the registries. Since the proxy handles the actual HTTP requests, we're limited to the authentication methods it already supports. Are you unable to use the standard registry authentication for your registry? |
@jankal mentioned it here: #9093, basically the method "HTTP Bearer" is needed, but is missing from dependabot authentication methods for private composer recipes: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/configuring-access-to-private-registries-for-dependabot#composer-repository |
|
@FalkoHilbert FYI we open sourced the proxy (https://github.com/dependabot/proxy) so you can contribute your changes directly to the repo |
6017411 to
d780008
Compare
|
@robaiken I have adjusted the commit/PR again. I now only process the token and no longer the auth_type. |
|
Addendum: Since the question of whether an adjustment is necessary in dependabot-core has already been clarified here by @JamieMagee, I wanted to explain once again why I still consider the adjustment to be necessary. We use Microsoft Azure DevOps for code management at our company, and we would like to use the "Dependabot Azure DevOps (Paklo) Extension" for this. Therefore, we also need to take the token into account in the dependabot-core and dependabot-updater-composer images. |
|
Hello @robaiken, Is there any news yet about the PR Review? We need this feature to set up Dependabot in our system accordingly. |
What are you trying to accomplish?
This PR should enable support for all authentication methods of composer.
should resolve #9093
Anything you want to highlight for special attention from reviewers?
I created the PR to provide an initial approach. Since I am not a Ruby developer, I hope that I have understood the code correctly. I am grateful for any support and would like to use this PR to initiate the feature implementation.
How will you know you've accomplished your goal?
with the changes in this PR it should be possible to use a composer registry with the parameter: token
Bpsw configuration:
Checklist