Explicitly use RFC2396 instead of DEFAULT_PARSER#12328
Merged
JamieMagee merged 1 commit intomainfrom May 27, 2025
Merged
Conversation
In Ruby 3.4 `URI::DEFAULT_PARSER` changed from `RFC2396` to `RFC3896`[1]. This change makes our use of `RFC2396` explicit instead of implicit. This migration was partially completed in #12170. This change just finishes the migration. This is a part of the Ruby 3.4 upgrade #11681 [1]: ruby/uri#107
JamieMagee
changed the title
RC2396 instead of DEFAULT_PARSERRFC2396 instead of DEFAULT_PARSER
jakecoffman
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In Ruby 3.4
URI::DEFAULT_PARSERchanged fromRFC2396toRFC39861. This change makes our use ofRFC2396explicit instead of implicit.This migration was partially completed in #12170. This change just finishes the migration.
This is a part of the Ruby 3.4 upgrade #11681
Anything you want to highlight for special attention from reviewers?
We should migrate from RFC2396 to RFC3986 at some point in the future. This work is tracked in #12327
How will you know you've accomplished your goal?
Checklist
Footnotes
https://github.com/ruby/uri/pull/107 ↩