Skip to content

Use explicit uri parser when fetching abs_uri regexp #12170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thavaahariharangit merged 4 commits into from
May 2, 2025
Merged

Use explicit uri parser when fetching abs_uri regexp #12170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
800ae87
Use explicit uri parser when fetching abs_uri regexp
andrcuns Apr 29, 2025
6c3a29d
Merge branch 'main' into use-explicit-uri-parser
andrcuns Apr 29, 2025
52e9c78
Merge branch 'main' into use-explicit-uri-parser
thavaahariharangit May 1, 2025
6ff5766
Merge branch 'main' into use-explicit-uri-parser
thavaahariharangit May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer/lib/dependabot/composer/helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def self.invalid_v2_requirement?(composer_json)

sig { params(dependency_url: String).returns(String) }
def self.clean_dependency_url(dependency_url)
return dependency_url unless URI::DEFAULT_PARSER.regexp[:ABS_URI].match?(dependency_url)
return dependency_url unless URI::RFC2396_PARSER.regexp[:ABS_URI].match?(dependency_url)

url = URI.parse(dependency_url)
url.user = nil
Expand Down
2 changes: 1 addition & 1 deletion python/lib/dependabot/python/package/package_details_fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ def name_regex
def validate_index(index_url)
return false unless index_url

return true if index_url.match?(URI::DEFAULT_PARSER.regexp[:ABS_URI])
return true if index_url.match?(URI::RFC2396_PARSER.regexp[:ABS_URI])

raise Dependabot::DependencyFileNotResolvable,
"Invalid URL: #{sanitized_url(index_url)}"
Expand Down
2 changes: 1 addition & 1 deletion uv/lib/dependabot/uv/package/package_details_fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@ def name_regex
def validate_index(index_url)
return false unless index_url

return true if index_url.match?(URI::DEFAULT_PARSER.regexp[:ABS_URI])
return true if index_url.match?(URI::RFC2396_PARSER.regexp[:ABS_URI])

raise Dependabot::DependencyFileNotResolvable,
"Invalid URL: #{sanitized_url(index_url)}"
Expand Down
Loading