Fix image-upgrade, test suite 'suite_group_clean_config', and test case 'test_switch_reload_all'#10
Closed
alisaycl96 wants to merge 2 commits intodentproject:masterfrom
Closed
Fix image-upgrade, test suite 'suite_group_clean_config', and test case 'test_switch_reload_all'#10alisaycl96 wants to merge 2 commits intodentproject:masterfrom
alisaycl96 wants to merge 2 commits intodentproject:masterfrom
Conversation
rothcar
previously approved these changes
Oct 14, 2021
Collaborator
rothcar
left a comment
rothcar
left a comment
There was a problem hiding this comment.
LGTM. Test suite still had some leftover hacks from our lab setup, thanks for catching that.
alisaycl96
force-pushed
the
master
branch
2 times, most recently
from
82937fd to
5e14dc0
Compare
isgmano
previously approved these changes
Oct 24, 2021
rothcar
previously approved these changes
Oct 26, 2021
taraschornyiplv
previously approved these changes
Oct 26, 2021
…ents.txt 2) Fix the image-upgrade by modifying the script name from 'onie-select' into 'dent_boot_select' 3) Fix the test suite 'suite_group_clean_config' by deleting 'infra_sw1_KEEPALIVED_CONF' and taking out the unnecessary code of staging file in 'test_clean_config.py' Signed-off-by: Alisa Li [email protected] Signed-off-by: Alisa Li <[email protected]>
alisaycl96
dismissed stale reviews from taraschornyiplv, rothcar, and isgmano
via
f2d173e
alisaycl96
force-pushed
the
master
branch
2 times, most recently
from
9ff6619 to
f2d173e
Compare
robimarko
approved these changes
Nov 9, 2021
|
LGTM, just remove the merge commit |
Author
|
This commit has been added to the new PR#11, so closed this one. |
mgheorghe
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Fix Password Policy for CI (#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <[email protected]>
hubogee
pushed a commit
to hubogee/testing
that referenced
this pull request
Aug 22, 2023
* Fix Password Policy for CI (dentproject#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <[email protected]>
hubogee
added a commit
to hubogee/testing
that referenced
this pull request
Aug 22, 2023
* Updated testbed files and Network interfaces files Signed-off-by: hubogee <[email protected]> * Optimize VPort Addition, Protocol Timing (dentproject#386) Signed-off-by: fkwilken <[email protected]> * Pr fix dockerfile (dentproject#10) (dentproject#388) * Fix Password Policy for CI (dentproject#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <[email protected]> * Added testbed device details: PDU, Mac, cpu architecture Signed-off-by: hubogee <[email protected]> --------- Signed-off-by: hubogee <[email protected]> Signed-off-by: fkwilken <[email protected]> Co-authored-by: Francisco <[email protected]>
hubogee
added a commit
to hubogee/testing
that referenced
this pull request
Aug 22, 2023
* Updated testbed files and Network interfaces files Signed-off-by: hubogee <[email protected]> * Optimize VPort Addition, Protocol Timing (dentproject#386) Signed-off-by: fkwilken <[email protected]> * Pr fix dockerfile (dentproject#10) (dentproject#388) * Fix Password Policy for CI (dentproject#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <[email protected]> * Added testbed device details: PDU, Mac, cpu architecture Signed-off-by: hubogee <[email protected]> --------- Signed-off-by: hubogee <[email protected]> Signed-off-by: fkwilken <[email protected]> Co-authored-by: Francisco <[email protected]> Signed-off-by: hubogee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alisa Li [email protected]