Running scripts in %PATH%: Uncaught NotFound

[quaos]

Describe the bug
I'm working on both Windows 10 and MacOS machines.
Now running on Windows, I'm trying to setup denon script to call denopack which is in my %HOME%\.deno\bin and already included in %PATH% but got error: Uncaught NotFound: The system cannot find the file specified. (os error 2)

To Reproduce

1. Create denon.json

"scripts": {
        "build": {
            "cmd": "denopack -c denopack.config.ts",
            "desc": "bundle my client.tsx file",
            "watch": false
        }
}

2. Check that denopack is installed in %PATH%

where denopack
C:\Users\qua_o\.deno\bin\denopack.cmd

denopack --version
denopack/0.9.0 windows-x86_64 deno-1.3.3

3. Run denon build

Expected behavior
It should run denopack -c denopack.config.ts

Configuration or Project
If applicable, add your denon configuration file or project so we can accurately test our solution.

Screenshots

denon build     
[*] [main] v2.4.0
[!] [#0] starting `denopack -c denopack.config.ts`
error: Uncaught NotFound: The system cannot find the file specified. (os error 2)
    at unwrapResponse (rt\10_dispatch_json.js:24:13)
    at sendSync (rt\10_dispatch_json.js:51:12)
    at opRun (rt\40_process.js:20:12)
    at Object.run (rt\40_process.js:104:17)
    at Runner.execute (https://deno.land/x/denon@2.4.0/src/runner.ts:169:17)
    at Object.exe (https://deno.land/x/denon@2.4.0/src/runner.ts:45:21)
    at Daemon.start (https://deno.land/x/denon@2.4.0/src/daemon.ts:62:29)
    at Daemon.iterate (https://deno.land/x/denon@2.4.0/src/daemon.ts:165:32)
    at iterate.next (<anonymous>)
    at https://deno.land/x/denon@2.4.0/denon.ts:162:18

Setup

• OS: Windows 10
• Deno version: 1.3.3
• Denon version: 2.4.0

Additional context
It can't neither find and run denon itself in %PATH%.

[quaos]

Just tested in Mac OS, it could run normally.

which denon
/Users/quaos/.deno/bin/denon

denon --version
[*] [main] v2.3.3

denon build
[*] [main] v2.3.3
[!] [#0] starting `denopack -c denopack.config.ts`
Generated denopack config: {
  input: "src/client.tsx",
  output: { dir: "./public/assets/js", sourcemap: true, format: "es" },
  plugins: [
    { name: "denopack-plugin-importResolver", resolveId: [Function: resolver] },
    { name: "denopack-plugin-cacheLoader", load: [AsyncFunction: load] },
    { name: "denopack-plugin-fileLoader", load: [AsyncFunction: load] },
    {
      name: "denopack-plugin-typescriptTransform",
      transform: [AsyncFunction: transform]
    }
  ]
}
denopack completed in 8275ms
[*] [daem] clean exit - denon is exiting ...

[notfilippo]

I think this could be an issue related to Deno.run. I will look into this.

[quaos]

I think this could be an issue related to Deno.run. I will look into this.

Thanks.

As for now, I'm using workaround like this:

    let cmd = ["denopack", "-c", "denopack.config.ts"];
    // Workaround for Windows
    // @ts-ignore TS2367
    if (/^(win|windows)$/.test(Deno.build.os)) {
      cmd = ["cmd", "/c"].concat(cmd);
    }
    const process: Deno.Process = Deno.run({
      cmd,
      env: Deno.env.toObject(),
    });

[eliassjogreen]

I can't seem to replicate this on my windows machine? But I will make a patch for it anyways as it seems like a harmless thing to do which should solve your and other peoples problems. #105 should fix your issue

[eliassjogreen]

Also update your deno version 😉

[PavelFlegr]

The fix for this seems to be causing issues for me. With cmd /c used, when denon restarts the process, it closes the cmd process but deno processes that were launched from it stay open. In my case this prevents the new process from binding to the same port and it crashes. Removing the fix solves this.

[eliassjogreen]

Relevant: #49 #7824

@PavelFlegr Think you could submit a pr for it and I will reopen this issue as it not properly closing seems like a bigger issue?

[eliassjogreen]

To solve this issue I think we should be able to manually just resolve the %path%/tool path and run that instead.

[PavelFlegr]

It's a very small change but here's the pr #110