Skip to content

Conversation

@WWRS
Copy link
Contributor

@WWRS WWRS commented Mar 27, 2025

resolves #6520

@WWRS WWRS requested a review from kt3k as a code owner March 27, 2025 15:24
@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (298fcac) to head (186f1aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6521   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files         576      576           
  Lines       43315    43315           
  Branches     6477     6477           
=======================================
+ Hits        41280    41281    +1     
+ Misses       1994     1993    -1     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, further up in this file, the libNames also seem to be different from the defaults. When I run cargo build on Win11, I get a file called unicode_width_crate.dll instead of libunicode_width_crate.dll. Not sure what happens on the other OSes.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for looking in to them!

I'll mark this commit as chore as the fix doesn't affect the user's code.

@kt3k kt3k changed the title fix(cli,http): fix typechecking errors chore(cli,http): fix typechecking errors Mar 28, 2025
@kt3k kt3k merged commit 61f9fd3 into denoland:main Mar 28, 2025
19 checks passed
@WWRS WWRS deleted the types branch March 30, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript errors in some scripts

2 participants