refactor: remove 'managed globals' infra #31318
Merged
+12
−649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Nov 17, 2025
| Module.wrapper = [ | ||
| `(function (exports, require, module, __filename, __dirname) { var { Buffer, clearImmediate, clearInterval, clearTimeout, global, process, setImmediate, setInterval, setTimeout } = Deno[Deno.internal].nodeGlobals; (() => {`, | ||
| // TODO(bartlomieju): these should actually be stored somewhere | ||
| `(function (exports, require, module, __filename, __dirname) { var { Buffer, clearImmediate, clearInterval, clearTimeout, global, process, setImmediate, setInterval, setTimeout } = globalThis; (() => {`, |
Member
Author
There was a problem hiding this comment.
I think we can now skip destructuring all these variables?
Member
Author
There was a problem hiding this comment.
I'll do that in a follow up
bartlomieju
commented
Nov 17, 2025
| nodeGlobals.setImmediate = nativeModuleExports["timers"].setImmediate; | ||
| nodeGlobals.setInterval = nativeModuleExports["timers"].setInterval; | ||
| nodeGlobals.setTimeout = nativeModuleExports["timers"].setTimeout; | ||
| globalThis.Buffer = nativeModuleExports["buffer"].Buffer; |
Member
Author
There was a problem hiding this comment.
All of this can be moved to 98_global_scope_shared.js
Member
Author
There was a problem hiding this comment.
I'll do that in a follow up too
Copilot finished reviewing on behalf of
bartlomieju
November 17, 2025 11:41
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the complex "managed globals" infrastructure that used V8 named property handlers and proxies to dynamically serve different global values based on whether code was running in node_modules. The refactor simplifies the implementation by directly assigning Node.js-specific globals to globalThis.
Key Changes
- Removed the proxy-based global interception system that provided context-dependent globals
- Simplified to direct
globalThisproperty assignments for Node.js globals (Buffer, process, timers, etc.) - Eliminated approximately 500 lines of complex Rust code and associated JavaScript glue
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ext/node/global.rs | Entire file deleted - removed V8 property handler callbacks and GlobalsStorage infrastructure |
| ext/node/lib.rs | Removed global module import, middleware references, and external references for property handlers |
| ext/node/polyfills/00_globals.js | File deleted - no longer needed to export nodeGlobals/denoGlobals objects |
| ext/node/polyfills/02_init.js | Changed from assigning to nodeGlobals object to directly assigning to globalThis |
| ext/node/polyfills/01_require.js | Updated Module.wrapper to destructure Node globals from globalThis instead of Deno.internal.nodeGlobals |
| runtime/js/99_main.js | Removed nodeGlobals import and removed it from internals object assignment |
| tools/core_import_map.json | Removed import map entry for deleted 00_globals.js file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also solve problems in #30905 (comment).