fix: FileFetcher correctly retries failed requests #24261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
approved these changes
Jun 19, 2024
Member
Author
|
Closing in favor of #24262 |
bartlomieju
added a commit
that referenced
this pull request
Jul 2, 2024
Reland of #24056 that doesn't suffer from the problem that was discovered in #24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
sbmsr
pushed a commit
to sbmsr/deno-1
that referenced
this pull request
Jul 2, 2024
Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that during reqwest upgrade (#24056) some
of the errors were reclassified and we no longer correctly retried failed requests.
I confirmed locally that the reproduction is now working correctly.
Closes #24260.