Formatter | HTML[style] | Inserts space before angled bracket

[m-dressler]

Version: Deno 2.5.4

When formatting HTML with deno, it adds a space in front of open brackets [

<div style="animation-name: animation-[value]" />

into

<div style="animation-name: animation- [value]" />

Prettier, in my opinion correctly, does NOT add a space in front of [.

[bartlomieju]

I think we need to update markup-fmt crate to the latest version and then try again.

[dingdong-vamshi]

this seems pretty doable having good html/deno exp my self
can you assigh me this issue ?
@m-dressler

[m-dressler]

@dingdong-vamshi seems @SHARMA1525 already took a stab

[isAdrisal]

I've checked with the latest version of markup_fmt (and malva) using dprint, and the extra space is still added. The change to ignore square braces in attribute values (and therefore not insert the space) would need to be made upstream in malva.

animation-name accepts a <custom-ident> value per the spec (mdn) where square braces are an invalid character.

Is this a common use case for a framework(s) that uses the square braces? I haven't dug too deeply but just trying to get a handle on if this is as simple as it looks or if there are potential breaking changes from handling square braces differently.

[m-dressler]

@isAdrisal I did a quick check and it does not appear it's part of any common framework. However, as in my use-case, many frameworks leverage mustache handlebars ({{}}), so if you want to handle variables separately from the framework, the square brackets are an easy alternative as they work well in all cases, except for style with deno's formatter. But might not warrant the fix for this more niche situation.

[SHARMA1525]

Could you please let me know whether this issue has been fixed? Also, tell me if I need to make any further changes.

[m-dressler]

I'll let maintainers comment on this at the PR level. So far yours is the only one, but it seems the lib should handle it, rather than a workaround in deno's src from what I saw in the comments