refactor: merge deno_fetch into deno_web

Author: iuioiua

Cargo.lock

@@ -13,7 +13,6 @@ members = [
   "ext/canvas",
   "ext/cron",
   "ext/crypto",
-  "ext/fetch",
   "ext/ffi",
   "ext/fs",
   "ext/http",
@@ -91,7 +90,6 @@ deno_cache = { version = "0.153.0", path = "./ext/cache" }
 deno_canvas = { version = "0.90.0", path = "./ext/canvas" }
 deno_cron = { version = "0.101.0", path = "./ext/cron" }
 deno_crypto = { version = "0.235.0", path = "./ext/crypto" }
-deno_fetch = { version = "0.245.0", path = "./ext/fetch" }
 deno_ffi = { version = "0.208.0", path = "./ext/ffi" }
 deno_fs = { version = "0.131.0", path = "./ext/fs" }
 deno_http = { version = "0.219.0", path = "./ext/http" }
@@ -442,8 +440,6 @@ opt-level = 3
 opt-level = 3
 [profile.release.package.deno_crypto]
 opt-level = 3
-[profile.release.package.deno_fetch]
-opt-level = 3
 [profile.release.package.deno_ffi]
 opt-level = 3
 [profile.release.package.deno_http]

Cargo.toml

@@ -93,6 +93,7 @@ deno_task_shell.workspace = true
 deno_telemetry.workspace = true
 deno_terminal.workspace = true
 deno_typescript_go_client_rust.workspace = true
+deno_web.workspace = true
 eszip.workspace = true
 libsui.workspace = true
 node_resolver = { workspace = true, features = ["graph", "sync"] }

cli/Cargo.toml

@@ -15,11 +15,10 @@ use deno_core::url::Url;
 use deno_error::JsError;
 use deno_error::JsErrorBox;
 use deno_lib::version::DENO_VERSION_INFO;
-use deno_runtime::deno_fetch;
-use deno_runtime::deno_fetch::CreateHttpClientOptions;
-use deno_runtime::deno_fetch::ResBody;
-use deno_runtime::deno_fetch::create_http_client;
 use deno_runtime::deno_tls::RootCertStoreProvider;
+use deno_web::fetch::CreateHttpClientOptions;
+use deno_web::fetch::ResBody;
+use deno_web::fetch::create_http_client;
 use http::HeaderMap;
 use http::StatusCode;
 use http::header::CONTENT_LENGTH;
@@ -33,7 +32,7 @@ use crate::util::progress_bar::UpdateGuard;
 #[derive(Debug, Error)]
 pub enum SendError {
   #[error(transparent)]
-  Send(#[from] deno_fetch::ClientSendError),
+  Send(#[from] deno_web::fetch::ClientSendError),
   #[error(transparent)]
   InvalidUri(#[from] http::uri::InvalidUri),
 }
@@ -44,7 +43,7 @@ pub struct HttpClientProvider {
   // it's not safe to share a reqwest::Client across tokio runtimes,
   // so we store these Clients keyed by thread id
   // https://github.com/seanmonstar/reqwest/issues/1148#issuecomment-910868788
-  clients_by_thread_id: Mutex<HashMap<ThreadId, deno_fetch::Client>>,
+  clients_by_thread_id: Mutex<HashMap<ThreadId, deno_web::fetch::Client>>,
 }
 
 impl std::fmt::Debug for HttpClientProvider {
@@ -111,7 +110,7 @@ pub struct DownloadError(pub Box<DownloadErrorKind>);
 pub enum DownloadErrorKind {
   #[class(inherit)]
   #[error(transparent)]
-  Fetch(deno_fetch::ClientSendError),
+  Fetch(deno_web::fetch::ClientSendError),
   #[class(inherit)]
   #[error(transparent)]
   UrlParse(#[from] deno_core::url::ParseError),
@@ -178,7 +177,7 @@ impl HttpClientResponse {
 
 #[derive(Debug)]
 pub struct HttpClient {
-  client: deno_fetch::Client,
+  client: deno_web::fetch::Client,
   // don't allow sending this across threads because then
   // it might be shared accidentally across tokio runtimes
   // which will cause issues
@@ -189,15 +188,15 @@ pub struct HttpClient {
 impl HttpClient {
   // DO NOT make this public. You should always be creating one of these from
   // the HttpClientProvider
-  fn new(client: deno_fetch::Client) -> Self {
+  fn new(client: deno_web::fetch::Client) -> Self {
     Self {
       client,
       _unsend_marker: deno_core::unsync::UnsendMarker::default(),
     }
   }
 
   pub fn get(&self, url: Url) -> Result<RequestBuilder, http::Error> {
-    let body = deno_fetch::ReqBody::empty();
+    let body = deno_web::fetch::ReqBody::empty();
     let mut req = http::Request::new(body);
     *req.uri_mut() = url.as_str().parse()?;
     Ok(RequestBuilder {
@@ -209,7 +208,7 @@ impl HttpClient {
   pub fn post(
     &self,
     url: Url,
-    body: deno_fetch::ReqBody,
+    body: deno_web::fetch::ReqBody,
   ) -> Result<RequestBuilder, http::Error> {
     let mut req = http::Request::new(body);
     *req.method_mut() = http::Method::POST;
@@ -229,7 +228,7 @@ impl HttpClient {
     S: serde::Serialize,
   {
     let json = deno_core::serde_json::to_vec(ser)?;
-    let body = deno_fetch::ReqBody::full(json.into());
+    let body = deno_web::fetch::ReqBody::full(json.into());
     let builder = self.post(url, body)?;
     Ok(builder.header(
       http::header::CONTENT_TYPE,
@@ -242,7 +241,7 @@ impl HttpClient {
     url: &Url,
     headers: HeaderMap,
   ) -> Result<http::Response<ResBody>, SendError> {
-    let body = deno_fetch::ReqBody::empty();
+    let body = deno_web::fetch::ReqBody::empty();
     let mut request = http::Request::new(body);
     *request.uri_mut() = http::Uri::try_from(url.as_str())?;
     *request.headers_mut() = headers;
@@ -328,7 +327,8 @@ impl HttpClient {
     &self,
     mut url: Url,
     headers: &HeaderMap<HeaderValue>,
-  ) -> Result<(http::Response<deno_fetch::ResBody>, Url), DownloadError> {
+  ) -> Result<(http::Response<deno_web::fetch::ResBody>, Url), DownloadError>
+  {
     let mut req = self.get(url.clone())?.build();
     *req.headers_mut() = headers.clone();
     let mut response = self
@@ -372,7 +372,7 @@ impl HttpClient {
 }
 
 pub async fn get_response_body_with_progress(
-  response: http::Response<deno_fetch::ResBody>,
+  response: http::Response<deno_web::fetch::ResBody>,
   progress_guard: Option<&UpdateGuard>,
 ) -> Result<(HeaderMap, Vec<u8>), JsErrorBox> {
   use http_body::Body as _;
@@ -440,8 +440,8 @@ where
 }
 
 pub struct RequestBuilder {
-  client: deno_fetch::Client,
-  req: http::Request<deno_fetch::ReqBody>,
+  client: deno_web::fetch::Client,
+  req: http::Request<deno_web::fetch::ReqBody>,
 }
 
 impl RequestBuilder {
@@ -452,11 +452,11 @@ impl RequestBuilder {
 
   pub async fn send(
     self,
-  ) -> Result<http::Response<deno_fetch::ResBody>, AnyError> {
+  ) -> Result<http::Response<deno_web::fetch::ResBody>, AnyError> {
     self.client.send(self.req).await.map_err(Into::into)
   }
 
-  pub fn build(self) -> http::Request<deno_fetch::ReqBody> {
+  pub fn build(self) -> http::Request<deno_web::fetch::ReqBody> {
     self.req
   }
 }

cli/http_util.rs

@@ -3,7 +3,6 @@
 use deno_core::error::AnyError;
 use deno_core::serde_json;
 use deno_core::url::Url;
-use deno_runtime::deno_fetch;
 use serde::de::DeserializeOwned;
 
 use crate::http_util;
@@ -89,7 +88,7 @@ impl std::fmt::Debug for ApiError {
 impl std::error::Error for ApiError {}
 
 pub async fn parse_response<T: DeserializeOwned>(
-  response: http::Response<deno_fetch::ResBody>,
+  response: http::Response<deno_web::fetch::ResBody>,
 ) -> Result<T, ApiError> {
   let status = response.status();
   let x_deno_ray = response
@@ -138,7 +137,7 @@ pub async fn get_package(
   registry_api_url: &Url,
   scope: &str,
   package: &str,
-) -> Result<http::Response<deno_fetch::ResBody>, AnyError> {
+) -> Result<http::Response<deno_web::fetch::ResBody>, AnyError> {
   let package_url = get_package_api_url(registry_api_url, scope, package);
   let response = client.get(package_url.parse()?)?.send().await?;
   Ok(response)

cli/registry.rs

@@ -28,7 +28,6 @@ use deno_core::serde_json::Value;
 use deno_core::serde_json::json;
 use deno_core::url::Url;
 use deno_resolver::collections::FolderScopedMap;
-use deno_runtime::deno_fetch;
 use deno_terminal::colors;
 use http_body_util::BodyExt;
 use serde::Deserialize;
@@ -923,7 +922,7 @@ async fn publish_package(
     package.config
   );
 
-  let body = deno_fetch::ReqBody::full(package.tarball.bytes.clone());
+  let body = deno_web::fetch::ReqBody::full(package.tarball.bytes.clone());
   let response = http_client
     .post(url.parse()?, body)?
     .header(

cli/tools/publish/mod.rs

@@ -832,7 +832,7 @@ pub fn worker_prepare_for_test(worker: &mut MainWorker) {
     .js_runtime
     .op_state()
     .borrow_mut()
-    .try_take::<deno_runtime::deno_fetch::Client>();
+    .try_take::<deno_web::fetch::Client>();
 }
 
 /// Yields to tokio to allow async work to process, and then polls