fix: do not omit args if value is 0 #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes quite an obvious bug (an unexpected behavior) in case an argument passed is 0.
The
0itself is a valid value for the affected argumentsCOUNTand, most importantly,BLOCK.COUNT 0should return an empty list (source)BLOCK 0means to never timeout (source)However, these arguments are currently omitted entirely when their value is 0.
This is caused by checking the argument values for being truthy that 0 is not a part of.
Proposed changes
Explicitly check argument values for not being
undefined(which is the only alternative value other than anumber, according to the type definitions).