Pull updates from template repo and add macOS platform support#164
Merged
Malcolmnixon merged 5 commits intomainfrom Mar 6, 2026
Merged
Pull updates from template repo and add macOS platform support#164Malcolmnixon merged 5 commits intomainfrom
Malcolmnixon merged 5 commits intomainfrom
Conversation
- D1: AGENTS.md - Add Agent Selection Guide section - D2: AGENTS.md - Add Test Source Filters section - D3: AGENTS.md - Add Requirements enforcement section - D4: code-quality-agent.md - Add Requirements Traceability quality gate (#4) - D5: requirements-agent.md - Add Requirements Format section; fix first bullet - D6: .editorconfig - Remove duplicate [*.{cs,vb}] section header and duplicate entries - D7: .vscode/tasks.json - Create VSCode tasks file - D8: build_on_push.yaml - Fix workflow name to 'Build on Push' - D9: test csproj - Add coverlet comment; move Implicit Usings before test deps - D10: software-developer.md - Add requirements linkage guidance - D11: README.md - Add Continuous Compliance feature - D12: README.md - Add License section with CLA sentence - D13: code-quality-agent.md - Add lint scripts to commands section - D14: build.yaml - Reorder quality checks (markdownlint, cspell, yamllint)
Co-authored-by: Malcolmnixon <[email protected]>
Copilot
AI
changed the title
[WIP] Pull in updates from the template repo
Pull updates from template repo and add macOS platform support
Mar 6, 2026
Malcolmnixon
requested changes
Mar 6, 2026
Co-authored-by: Malcolmnixon <[email protected]>
Malcolmnixon
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs SpdxTool with updated TemplateDotNetTool patterns and extends CI + requirements traceability to treat macOS as a first-class supported platform.
Changes:
- Add macOS to CI build/integration/targets test matrices and introduce a macOS platform requirement with test evidence links.
- Sync agent guidance docs and workflow step ordering to match the template patterns.
- Add standard VS Code tasks and minor documentation/config cleanups (README license section,
.editorconfigdedupe, test project csproj ordering).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/DemaConsulting.SpdxTool.Tests/DemaConsulting.SpdxTool.Tests.csproj |
Reorders implicit usings ItemGroup and clarifies coverlet collector behavior. |
requirements.yaml |
Adds macos@ source filter docs and introduces SpdxTool-Plt-MacOS requirement linked to platform evidence tests. |
README.md |
Adds “Continuous Compliance” bullet and a License section with absolute license link. |
AGENTS.md |
Adds agent selection guide, requirements enforcement notes, source filter guidance, and updates CI/CD platform wording. |
.vscode/tasks.json |
Adds common VS Code tasks (build/validate/format/lint/req enforcement). |
.github/workflows/build_on_push.yaml |
Renames workflow to “Build on Push”. |
.github/workflows/build.yaml |
Reorders quality steps, adds macOS to matrices, and simplifies OS short-name derivation. |
.github/agents/software-developer.md |
Adds reminder to link work back to requirements.yaml. |
.github/agents/requirements-agent.md |
Updates guidance to focus on creating requirements and documents required format. |
.github/agents/code-quality-agent.md |
Adds requirements traceability as a quality gate and documents lint helpers. |
.editorconfig |
Removes redundant per-language section to reduce duplication. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Syncs SpdxTool with the latest TemplateDotNetTool patterns and adds macOS as a fully tested and requirements-tracked platform.
Template Sync
Agent guidance (
AGENTS.md+.github/agents/)windows@,ubuntu@,macos@,net8.0@,dotnet8.x@prefixesdotnet reqstream --enforcecommand)code-quality-agent.md: added Requirements Traceability as quality gate Add support for variables in workflow files. #4; addedlint.sh/lint.batconvenience commandsrequirements-agent.md: added "Requirements Format" section; fixed first bullet to "Creating new requirements"software-developer.md: added "Link to requirements inrequirements.yaml" to self-validation guidanceWorkflows
build_on_push.yaml: renamed workflow fromBuild→Build on Pushbuild.yaml: reordered quality-check steps to markdownlint → cspell → yamllint; simplifiedOS_SHORTsed tosed 's/-latest//'matching the template patternConfig / IDE
.editorconfig: removed duplicate[*.{cs,vb}]section with redundantdotnet_sort_system_directives_first/dotnet_separate_import_directive_groupsentries.vscode/tasks.json: new file with standard tasks (build, validate, format, lint-all, verify-requirements, etc.)Documentation
README.md: added "Continuous Compliance" feature bullet and## Licensesection with CLA sentence;[link-license]uses absolute URL for correct rendering on nuget.orgTest project
DemaConsulting.SpdxTool.Tests.csproj: moved Implicit UsingsItemGroupbefore test-framework deps; added explanatory comments forcoverlet.collectormacOS Platform Support
macos-latesttobuild,integration-test(3 OS × 3 .NET = 9 combos), andtargets-integration-testmatrices inbuild.yamlOS_SHORTusessed 's/-latest//'producingwindows,ubuntu,macos— automatically handles any future platforms without sed chain changesmacos@TestNamesource-filter prefix torequirements.yamlheaderSpdxTool-Plt-MacOSrequirement linked tomacos@SpdxTool_Validateand all five MSBuild targets testsAGENTS.mdCI/CD section: Windows/Linux → Windows/Linux/macOSType of Change
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
macOS CI jobs will initially show the
SpdxTool-Plt-MacOSrequirement as unsatisfied until the first macOS CI run produces TRX results — this is expected behaviour per therequirements.yamlheader note about platform-specific requirements requiring CI evidence.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.