scrvUSD mainnet 182day deployment script #1216
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues
Description
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled
## [Reviewer Name].If the PR doesn't touch Solidity, the corresponding checklist can
be removed.
[[Reviewer Name]]
approvecalls useforceApprove?transfercalls usesafeTransfer?transferFromcalls usemsg.senderas thefromaddress?token spend?
call,delegatecall,staticcall,transfer,send)successboolean checked to handle failed calls?delegatecall, are there strict access controls on theaddresses that can be called? It shouldn't be possible to
delegatecallarbitrary addresses, so the list of possible targets should either be
immutable or tightly controlled by an admin.
nonReentrant?not a concern or how it's mitigated?
memory variables?
issues?
payablefunctions restricted to avoid stuck ether?catch underflows?
Safefunctions are altered, are potential underflows andoverflows caught so that a failure flag can be thrown?
covering the full input space?