Skip to content

chore: fix clippy warnings on main #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

chore: fix clippy warnings on main #3264

merged 2 commits into from
Feb 25, 2025

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 25, 2025 •
edited
Loading

Description

Similarly to #3262 I would like to use compiler warnings and clippy locally to find places that need to be changed after DataFusion upgrade. This means I would to have main have a clean clippy run

I just did what clippy told me to mostly

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Feb 25, 2025
@alamb alamb force-pushed the alamb/cleanup_clippy branch from 5885dbc to 5798fac Compare February 25, 2025 17:12
@github-actions
Copy link

github-actions bot commented Feb 25, 2025

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

alamb
alamb commented Feb 25, 2025
View reviewed changes
python/src/lib.rs
/// This will acquire the internal lock since it is a mutating operation!
pub fn load_version(&self, py: Python, version: i64) -> PyResult<()> {
py.allow_threads(|| {
#[allow(clippy::await_holding_lock)]
Copy link
Contributor Author

@alamb alamb Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy is complaining about this -- it might be a real issue, but I didn't want to mess with it is as part of this PR. This PR makes the situation better in my opinion, as now the clippy warning is explicit in the code

@alamb alamb changed the title fix: fix clippy warnings on main fix: fix clippy warnings on main Feb 25, 2025
@alamb alamb changed the title fix: fix clippy warnings on main chore: fix clippy warnings on main Feb 25, 2025
@alamb alamb marked this pull request as ready for review February 25, 2025 17:32
roeap
roeap approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @alamb!

@roeap roeap enabled auto-merge February 25, 2025 17:57
@codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.07%. Comparing base (ddad194) to head (60cffa5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
python/src/lib.rs 0.00% 6 Missing ⚠️
crates/catalog-unity/src/datafusion.rs 0.00% 1 Missing ⚠️
crates/core/src/delta_datafusion/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3264      +/-   ##
==========================================
- Coverage   72.08%   72.07%   -0.02%     
==========================================
  Files         143      143              
  Lines       45698    45701       +3     
  Branches    45698    45701       +3     
==========================================
- Hits        32941    32937       -4     
- Misses      10687    10689       +2     
- Partials     2070     2075       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roeap roeap added this pull request to the merge queue Feb 25, 2025
Merged via the queue into delta-io:main with commit c1bbc4c Feb 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roeap roeap roeap approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127

@fvaleye fvaleye Awaiting requested review from fvaleye

@ion-elgreco ion-elgreco Awaiting requested review from ion-elgreco ion-elgreco is a code owner

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

@hntd187 hntd187 Awaiting requested review from hntd187 hntd187 is a code owner

Assignees

No one assigned

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb @roeap