[VARIANT] Create low-level Variant library with json_to_variant implementation #1030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR introduces a low-level Variant library with the
json_to_variantfunction which is similar toparse_jsonin Spark. The function is written in such a way that the caller owns the memory that the output is written to. The caller needs to implementVariantMemoryManagerwith the methodsborrow_value_buffer,borrow_metadata_buffer,ensure_value_buffer_sizeandensure_metadata_buffer_size.How was this change tested?
Several unit tests to manually compare the constructed variants with raw bytes. Implementing
variant_to_jsonshould increase coverage and make more tests easier. While the PR currently contains many tests, we will be adding more tests.TODO: