chore(cgt): sync develop #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystemNoop to Devstack (ethereum-optimism#17300) * feat(op-acceptance-tests): port interop smoke tests * feat(op-acceptance-tests): linter
… latitude. (ethereum-optimism#17296) It doesn't need lots of resources and we're seeing network flakiness so try uploading from a different network.
* op-devstack: add sync-tester with ext cl config * op-devstack: try setting up remote L2 chain * op-devstack: use remote EL and CL for L1 nodes * op-devstack: fix L2CL from sequencer to verifier * op-devstack: remove redundant configs * op-acceptance-tests: use RPC for CI * op-acceptance-tests: skip tests until CI allows tests using external endpoints * circleci: attempt CI endpoints * op-devstack: address comments from PR * op-devstack: address comments from PR
…timism#17281) * feat: add feature flagging functionality to SystemConfig Adds a function to the SystemConfig for feature flagging. Features are identified by 32 byte strings and can be toggled on or off by the ProxyAdmin or the owner of the ProxyAdmin. Note that this commit does not actually use any feature flags but demonstrates what a feature flag would look like by adding in the flag for the ETHLockbox feature. * feat: update for PR feedback * fix: small test tweaks * fix: broken test
…6817) * feat(op-acceptance-tests): add more sysgo tests. * fix(op-devstack): ecotone; fees. Use the actual increase in the L1FeeVault balance. This is because in Ecotone, the L1 fee includes both base fee and blob base fee components. * fix(op-acceptance-tests): skipping flaky/broken tests. * fix(op-acceptance-tests): interop; TestInteropSystemSupervisor * fix(op-acceptance-tests): justfile; exit early for gateless. * fix(op-acceptance-tests): tidied justfile * fix(op-acceptance-tests): fix ecotone fees. The recent commit changed L1 fee calculation to use vault balance increases as the source of truth, but base fee and priority fee calculations were still using the old method (calculating from block data). Made all fee calculations by making vault increases the source of truth. * fix(op-acceptance-tests): increase default timeout for gateless mode. * chore: Conditional logic * fix(op-acceptance-tests): TestSuperRootWithdrawal nonce issue and timeouts * fix(op-acceptance-tests): re-enable safeheaddb tests after ethereum-optimism#17083 fix * fix(op-acceptance-tests): security; env var injection The LOG_LEVEL environment variable is used directly in shell command execution without validation or sanitization, allowing command injection attacks. * feat(op-acceptance-tests): justfile; allow gateless for sysext. Allow gateless mode to run for an external devnet ('sysext' orchestrator) * clean(op-acceptance-tests): circleci; removed memory-base job The new memory-all is a superset of memory-base; so we don't need both. * fix(op-devstack): enhance Ecotone fee validation and enforce operator vault constraints - Add validation that receipt L1Fee matches L1FeeVault increase - Restore receipt-based fee calculations for validation (baseFee and L2Fee) - Enforce OperatorVault must be zero in Ecotone (operator fees introduced in Isthmus) - Exclude OperatorVault from total fee calculations in Ecotone - Add comprehensive receipt fee validation checks * fix(op-devstack): ecotone; cross-validation of fees Added cross-validation between receipt and vault fees: The code now verifies that: - receiptBaseFee (block.BaseFee × gasUsed) equals vaultBaseFee (BaseFeeVault increase) - receiptL2Fee (effectiveGasPrice × gasUsed) equals vaultL2Fee (BaseFee + SequencerFee vault increases) * fix(op-devstack): supervisor sync status L1 mismatch retry Increase retry attempts and handle L1 sync mismatch errors to fix flaky TestExecMsgDifferEventIndexInSingleTx. * fix(op-acceptance-tests): TestPostInteropUpgradeComprehensive Made it serial due to flakiness. * feat(op-acceptance-tests): ci; tweak timeout and verbosity. * fix(op-acceptance-tests): exclude interop tests from ci tag These in-memory devstack tests don't work reliably with gotestsum's retry mechanism. They run fine via op-acceptor in the memory-all job but fail when run directly with go test in go-tests-short. Adding !ci build constraint to exclude from standard CI test suite while keeping them available for dedicated acceptance test runs. * fix(op-acceptance-tests): TestWithdrawal nonce synchronization Use fresh EOA instance for withdrawal initiation to prevent nonce conflicts when shared L1/L2 keys encounter retry logic. * chore(op-acceptance-tests): TestPreNoInbox marked as flaky * chore(op-acceptance-tests): test limiting concurrency * chore(op-acceptance-tests): self-hosted runner Default to using our self-hosted runners. Accept a parameter which allows individual jobs to opt-out and use CCI/Cloud runners. --------- Co-authored-by: Jan Nanista <[email protected]>
…imism#16755) Stop running (sysgo/in-memory) acceptance tests as unit tests in other workflows
ashitakah
approved these changes
Sep 4, 2025
agusduha
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.