fix: proposal validator pre-pr #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusduha
reviewed
Aug 12, 2025
| /// @title ProposalValidator_HashProposalWithModule_Test | ||
| /// @notice Tests for the hashProposalWithModule function | ||
| contract ProposalValidator_HashProposalWithModule_Test is ProposalValidator_TestInit { | ||
| contract ProposalValidator_Uncategorized_Test is ProposalValidator_TestInit { |
Member
There was a problem hiding this comment.
HashProposalWithModule is not a function right?
Member
There was a problem hiding this comment.
Ok lets add a comment on why the Uncategorized so its clear what we are testing
agusduha
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-1004
Complies with pre-pr rules for
ProposalValidatortests by:ProposalValidatorForTestout of the test files