fix: make validator immutable #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xiamflux
reviewed
Aug 8, 2025
| ReinitializableBase(1) | ||
| { | ||
| ) { | ||
| _transferOwnership(_owner); |
There was a problem hiding this comment.
Why do we remove the initialization of the proposal types, again? Forgetting to do it might lead to some issues when submitting proposals. Even when we trust the owner will do it for sure maybe we want to avoid even the chance it happens.
Member
Author
There was a problem hiding this comment.
I think its okey as long as its part of the deployment script, will make sure to define it in the documentation
0xiamflux
previously approved these changes
Aug 11, 2025
agusduha
reviewed
Aug 11, 2025
agusduha
previously approved these changes
Aug 12, 2025
0xChin
previously approved these changes
Aug 12, 2025
0xiamflux
changed the base branch from
fix/misc-findings
to
sc-feat/permissionless-proposals
0xiamflux
dismissed stale reviews from 0xChin, agusduha, and themself
The base branch was changed.
0xiamflux
force-pushed
the
fix/pp-make-contract-immutable
branch
from
50853f8 to
29076c6
Compare
agusduha
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-979