fix: add approval timing check #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusduha
reviewed
Aug 6, 2025
|
|
||
| // since the attestations are updated daily we should only allow attestations | ||
| // created before the last voting cycle of the proposal | ||
| // check if attestation was created after the previous voting cycle |
Member
There was a problem hiding this comment.
Should we fix this comment too?
Member
Author
There was a problem hiding this comment.
I removed the last comment, I think this is good, wdyt?
// since the attestations are updated daily we should only allow attestations
// created before the last voting cycle of the proposal
|
Do we have a test for the |
Member
Author
We totally should! Great catch 🔥 |
0xiamflux
approved these changes
Aug 6, 2025
agusduha
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-971