fix: pp minors #458
fix: pp minors #458
Conversation
| //////////////////////////////////////////////////////////////*/ | ||
|
|
||
| /// @notice The Optimism Governor contract that will handle the voting phase. | ||
| IOptimismGovernor public immutable GOVERNOR; |
There was a problem hiding this comment.
Should we also do the same for the governor and move to initialize?
There was a problem hiding this comment.
I'm not really sure, it could somehow make sense to change the schema uid if the resolver changes by any chance
but I wonder in which context another governor would be deployed given that it is a proxy, and in case a new one is deployed, how compatible would it be with the existing validator
0xChin
changed the base branch from
chore/pp-fixed-version
to
sc-feat/permissionless-proposals
0xChin
changed the base branch from
sc-feat/permissionless-proposals
to
fix/ir-findings
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "slot": "104", | ||
| "type": "mapping(bytes32 => struct ProposalValidator.ProposalData)" | ||
| "slot": "106", | ||
| "type": "mapping(uint256 => struct ProposalValidator.ProposalData)" |
There was a problem hiding this comment.
Bug: Storage Corruption in Contract Upgrade
Critical storage layout corruption in the ProposalValidator contract. New state variables approvedProposerAttestationSchemaUid and topDelegatesAttestationSchemaUid were introduced as stored variables (previously immutable), inserting at slots 101 and 102. This shifts existing storage variables: proposalDistributionThreshold (101->103), votingCycles (102->104), proposalTypesData (103->105), and _proposals (104->106). Furthermore, the _proposals mapping's key type changed from bytes32 to uint256. These breaking changes cause data corruption and render existing state (including all prior proposals) inaccessible for deployed proxies, making the contract unusable after upgrade.
Locations (3)
* chore: use fixed variable for contract version * refactor: rename proposalHash to proposalId for governor consistency * chore: move attestation schemas uids to initialize function * chore: specify target modules in submit functions * refactor: proper naming for modules settings * fix: pre-pr
* chore: use fixed variable for contract version * refactor: rename proposalHash to proposalId for governor consistency * chore: move attestation schemas uids to initialize function * chore: specify target modules in submit functions * refactor: proper naming for modules settings * fix: pre-pr
No description provided.