Skip to content

fix: ir findings #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 28, 2025
Merged

fix: ir findings #449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
142d129
fix: check hash after proposal (#447)
0xChin Jul 18, 2025
d18f80b
refactor: fetch proposal types configurator externally (#448)
0xChin Jul 18, 2025
a32244f
fix: check for uninitialized voting modules (#446)
0xChin Jul 21, 2025
74a0363
feat: add check in approve if proposal has moved to vote (#450)
0xOneTony Jul 21, 2025
154065c
fix: msg sender to be consistent (#451)
0xOneTony Jul 21, 2025
261fc72
fix: approved proposer schema (#452)
0xOneTony Jul 21, 2025
6a4a6fc
fix: voting cycle validity on submit (#454)
0xOneTony Jul 22, 2025
6638584
fix: budget cap dos (#453)
0xOneTony Jul 22, 2025
505ae50
fix: move to vote logic (#455)
0xChin Jul 23, 2025
253cc6e
fix: normalize validate functions (#456)
0xChin Jul 24, 2025
332b1f3
chore: use fixed variable for contract version (#457)
0xChin Jul 24, 2025
2499ac1
fix: pp minors (#458)
0xChin Jul 24, 2025
39b6ca9
fix: descrepancies (#464)
0xOneTony Jul 28, 2025
96371dd
fix: add total budget overflow check
0xOneTony Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/contracts-bedrock/interfaces/governance/IProposalValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ interface IProposalValidator is ISemver {
uint256 _duration,
uint256 _votingCycleDistributionLimit,
uint256 _proposalDistributionThreshold,
bytes32 _approvedProposerAttestationSchemaUid,
bytes32 _topDelegatesAttestationSchemaUid,
ProposalType[] memory _proposalTypes,
ProposalTypeData[] memory _proposalTypesData
) external;
Expand All @@ -190,9 +188,9 @@ interface IProposalValidator is ISemver {

function initVersion() external view returns (uint8);

function approvedProposerAttestationSchemaUid() external view returns (bytes32);
function APPROVED_PROPOSER_ATTESTATION_SCHEMA_UID() external view returns (bytes32);

function topDelegatesAttestationSchemaUid() external view returns (bytes32);
function TOP_DELEGATES_ATTESTATION_SCHEMA_UID() external view returns (bytes32);

function OPTIMISTIC_MODULE_PERCENT_DIVISOR() external view returns (uint256);

Expand All @@ -206,6 +204,8 @@ interface IProposalValidator is ISemver {
);

function __constructor__(
IOptimismGovernor _governor
IOptimismGovernor _governor,
bytes32 _approvedProposerAttestationSchemaUid,
bytes32 _topDelegatesAttestationSchemaUid
) external;
}
72 changes: 36 additions & 36 deletions packages/contracts-bedrock/snapshots/abi/ProposalValidator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,34 @@
"internalType": "contract IOptimismGovernor",
"name": "_governor",
"type": "address"
},
{
"internalType": "bytes32",
"name": "_approvedProposerAttestationSchemaUid",
"type": "bytes32"
},
{
"internalType": "bytes32",
"name": "_topDelegatesAttestationSchemaUid",
"type": "bytes32"
}
],
"stateMutability": "nonpayable",
"type": "constructor"
},
{
"inputs": [],
"name": "APPROVED_PROPOSER_ATTESTATION_SCHEMA_UID",
"outputs": [
{
"internalType": "bytes32",
"name": "",
"type": "bytes32"
}
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [],
"name": "GOVERNOR",
Expand All @@ -36,6 +59,19 @@
"stateMutability": "view",
"type": "function"
},
{
"inputs": [],
"name": "TOP_DELEGATES_ATTESTATION_SCHEMA_UID",
"outputs": [
{
"internalType": "bytes32",
"name": "",
"type": "bytes32"
}
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [
{
Expand All @@ -54,19 +90,6 @@
"stateMutability": "nonpayable",
"type": "function"
},
{
"inputs": [],
"name": "approvedProposerAttestationSchemaUid",
"outputs": [
{
"internalType": "bytes32",
"name": "",
"type": "bytes32"
}
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [],
"name": "initVersion",
Expand Down Expand Up @@ -112,16 +135,6 @@
"name": "_proposalDistributionThreshold",
"type": "uint256"
},
{
"internalType": "bytes32",
"name": "_approvedProposerAttestationSchemaUid",
"type": "bytes32"
},
{
"internalType": "bytes32",
"name": "_topDelegatesAttestationSchemaUid",
"type": "bytes32"
},
{
"internalType": "enum ProposalValidator.ProposalType[]",
"name": "_proposalTypes",
Expand Down Expand Up @@ -502,19 +515,6 @@
"stateMutability": "nonpayable",
"type": "function"
},
{
"inputs": [],
"name": "topDelegatesAttestationSchemaUid",
"outputs": [
{
"internalType": "bytes32",
"name": "",
"type": "bytes32"
}
],
"stateMutability": "view",
"type": "function"
},
{
"inputs": [
{
Expand Down
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/snapshots/semver-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@
"sourceCodeHash": "0x18f43b227decd0f2a895b8b55e23fa6a47706697c272bbf2482b3f912be446e1"
},
"src/governance/ProposalValidator.sol:ProposalValidator": {
"initCodeHash": "0x4171ca5a66e60a2a3715dc3108d76f985eb16937d71197c74ee0465461e8f9fe",
"sourceCodeHash": "0xa95d144dad3bb25ef0ac0e4ae9039b1ee5304e86e9ef7c1726d263f63598f864"
"initCodeHash": "0xd96122c73104bff67f8493e0e0d9d7aeeb6a631ecd52d5572a8a21b724591ad9",
"sourceCodeHash": "0x857b3e452c59b2263d812868916e20aafb81380f1438616d913141ae45a6b806"
},
"src/legacy/DeployerWhitelist.sol:DeployerWhitelist": {
"initCodeHash": "0x53099379ed48b87f027d55712dbdd1da7d7099925426eb0531da9c0012e02c29",
Expand Down
22 changes: 4 additions & 18 deletions packages/contracts-bedrock/snapshots/storageLayout/ProposalValidator.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,46 +34,32 @@
"slot": "52",
"type": "uint256[49]"
},
{
"bytes": "32",
"label": "approvedProposerAttestationSchemaUid",
"offset": 0,
"slot": "101",
"type": "bytes32"
},
{
"bytes": "32",
"label": "topDelegatesAttestationSchemaUid",
"offset": 0,
"slot": "102",
"type": "bytes32"
},
{
"bytes": "32",
"label": "proposalDistributionThreshold",
"offset": 0,
"slot": "103",
"slot": "101",
"type": "uint256"
},
{
"bytes": "32",
"label": "votingCycles",
"offset": 0,
"slot": "104",
"slot": "102",
"type": "mapping(uint256 => struct ProposalValidator.VotingCycleData)"
},
{
"bytes": "32",
"label": "proposalTypesData",
"offset": 0,
"slot": "105",
"slot": "103",
"type": "mapping(enum ProposalValidator.ProposalType => struct ProposalValidator.ProposalTypeData)"
},
{
"bytes": "32",
"label": "_proposals",
"offset": 0,
"slot": "106",
"slot": "104",
"type": "mapping(uint256 => struct ProposalValidator.ProposalData)"
}
]
Loading