fix: check for uninitialized voting modules

[0xChin]

Closes OPT-937
Fixes [L-0] Voting Module is not validated during submission

Regarding the voting module changed validation. It is not required given that the move to vote function retrieves the proposalHash based on current ProposalTypeConfigurator config. In case the votingModuleAddress has been changed for a given ProposalType, the computed hash won't be the same and the move to vote function will revert due to an unexisting proposal.

In case we anyways want to add this validation for better dev experience, it would involve a design modification, given that proposal data in move to vote functions is retrieved from the computed hash based on the proposal data, including the proposal types configurator voting module

[linear]

OPT-937 [L-0] Voting Module is not validated during submission

[0xOneTony]

lgtm but lets merge #448 first

[cursor]

Bug: Proposal Validation Fails for Zero Voting Module

The validation for an invalid voting module in submitUpgradeProposal, submitCouncilMemberElectionsProposal, and submitFundingProposal incorrectly checks bytes(proposalTypeConfig.name).length == 0. This allows proposals with a non-empty name but an invalid (zero) module address to pass validation. The check should instead directly validate if the module address is zero (votingModule == address(0)), which aligns with the ProposalValidator_InvalidVotingModule error's intent.

packages/contracts-bedrock/src/governance/ProposalValidator.sol#L342-L346

optimism/packages/contracts-bedrock/src/governance/ProposalValidator.sol

Lines 342 to 346 in 05eda74

	// Validate voting module exists
	if (bytes(proposalTypeConfig.name).length == 0) {
	revert ProposalValidator_InvalidVotingModule();
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎