refactor: proposal type data struct #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xOneTony
requested changes
May 29, 2025
Member
0xOneTony
left a comment
0xOneTony
left a comment
There was a problem hiding this comment.
Good job so far! Lets try to be a bit more careful with natspecs and variable naming both in src and in tests. We want to be as verbose as possible and anyone reading our code should be able to understand at least on a high level what we do.
I am also considering removing the "proposalTypeConfigurator" name all together and rename to "votingModule" but thats for a different PR.
packages/contracts-bedrock/src/governance/ProposalValidator.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/governance/ProposalValidator.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/test/governance/ProposalValidator.t.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/governance/ProposalValidator.sol
Outdated
Show resolved
Hide resolved
0xChin
changed the title
0xOneTony
reviewed
Jun 2, 2025
packages/contracts-bedrock/src/governance/ProposalValidator.sol
Outdated
Show resolved
Hide resolved
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
* refactor: use proposalTypesData mapping * docs: improve natspec * feat: add mismatched lenghts check in contract initializer * fix: emit ProposalTypeDataSet with missing arg * refactor: correct naming in test helper functions * refactor: correct variable naming in fuzz tests * perf: remove redundant fields from ProposalData struct * chore: run pre-pr * chore: improve code formatting
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
* refactor: use proposalTypesData mapping * docs: improve natspec * feat: add mismatched lenghts check in contract initializer * fix: emit ProposalTypeDataSet with missing arg * refactor: correct naming in test helper functions * refactor: correct variable naming in fuzz tests * perf: remove redundant fields from ProposalData struct * chore: run pre-pr * chore: improve code formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-800, OPT-807
🐧 ?