feat: admin functions #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidator-upgradeability-2 Signed-off-by: Chiin <[email protected]>
…in-functions Signed-off-by: Chiin <[email protected]>
0xOneTony
reviewed
May 26, 2025
Member
0xOneTony
left a comment
0xOneTony
left a comment
There was a problem hiding this comment.
I noticed we set the voting cycle data on initiallization but I dont think this is needed, wdyt?
| { | ||
| _setMinimumVotingPower(_minimumVotingPower); | ||
| _setVotingCycleBlock(_votingCycleBlock); | ||
| _setVotingCycleData(_cycleNumber, _startBlock, _duration, _votingCycleDistributionLimit); |
Member
There was a problem hiding this comment.
Do we need to set the voting cycle data on initiallization?
Member
Author
There was a problem hiding this comment.
I'd recommend keeping it as it is required for moving to vote any proposal. This is being further discussed internally regarding how the logic will be done. I prefer to keep this for the moment
Member
There was a problem hiding this comment.
thinking more about this maybe we can keep it and even if no cycle is active or planned we could always use the previous one i guess
0xOneTony
approved these changes
May 28, 2025
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
* feat: add upgradeability to ProposalValidator contract * chore: fix styling * feat: add admin functions and tests * chore: more descriptive variables naming * test: expect event emissions * test: use fuzzing for setter functions * chore: run pre-pr * docs: use correct natspec in ProosalValidator contract * feat: add semver * feat: add reinitializable base * chore: run pre-pr * chore: run pre-pr --------- Signed-off-by: Chiin <[email protected]>
0xOneTony
pushed a commit
that referenced
this pull request
Jul 29, 2025
* feat: add upgradeability to ProposalValidator contract * chore: fix styling * feat: add admin functions and tests * chore: more descriptive variables naming * test: expect event emissions * test: use fuzzing for setter functions * chore: run pre-pr * docs: use correct natspec in ProosalValidator contract * feat: add semver * feat: add reinitializable base * chore: run pre-pr * chore: run pre-pr --------- Signed-off-by: Chiin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.